Dark-Alex-17
27101909e0
state_updates::apply merged EVERY top-level key of an llm/agent node's JSON
output into graph state whenever the node had an output_schema, and
structured::extract never validated the output against that schema. Any
prompt text able to steer the model — including plan/diff text pasted from a
repo under review — could therefore plant an undeclared key (e.g.
verification_commands) into state and overwrite a caller-declared value
before a downstream script consumed it.
- apply() now takes the node's output_schema and merges only keys present in
schema.properties; undeclared keys are dropped. No schema, or a schema
without an object properties map, merges nothing.
- Nodes without output_schema are unchanged (None == the old false path);
explicit state_updates are unchanged and still see the full output via
{{output.<key>}}, which remains the author-controlled way to lift a key.
- Callers: llm.rs, agent.rs (x2), rag.rs (None).
- Sweep test bundled_graph_output_schemas_declare_every_key_relied_on: for
every bundled graph, every consumed state key has a declared writer
(initial_state, variable, state_updates target, map key, script-emitted key,
or an output_schema property), and no schema node's field list names a key
its schema omits — so this restriction cannot silently break a shipped
graph. It passes with no graph.yaml changes.
- graph.example.yaml documents the declared-keys-only merge; the residual
disclosed in 665fee9's README/docstring notes is now recorded as closed.
151 lines
8.3 KiB
Markdown
151 lines
8.3 KiB
Markdown
# Review Gauntlet
|
||
|
||
A graph-based post-implementation review gate — **"the done gate"**. An
|
||
orchestrator that must not claim *done* without green reviews spawns this agent
|
||
once instead of judging trigger rules and parsing verdict sentinels itself. The
|
||
graph structure makes skipping a lane or misreading a verdict impossible:
|
||
trigger signals are computed by a script, lanes run as isolated parallel
|
||
sub-agents, and the final verdict is a deterministic regex gate — an LLM never
|
||
gets the chance to rationalize past it.
|
||
|
||
```mermaid
|
||
flowchart TD
|
||
parse["parse<br/>(llm: extract request facts)"] --> signals["signals<br/>(script: deterministic diff facts)"]
|
||
parse -. "fallback" .-> pfault["parse_fault<br/>(script: PIPELINE-FAULT marker)"]
|
||
pfault --> gate
|
||
signals --> select["select_lanes<br/>(llm: ADDITIVE-only judgment)"]
|
||
select --> build["build_items<br/>(script: rules floor ∪ additions;<br/>forced lanes override exactly)"]
|
||
select -. "fallback" .-> dlanes["default_lanes<br/>(script: deterministic degraded<br/>selection — wider, never narrower)"]
|
||
dlanes --> build
|
||
build --> mcr["map: code-review"] & madv["map: adversary"] & msec["map: security"] & mpb["map: probe"]
|
||
mcr -->|"over: 0-or-1 items"| rcr[["code-reviewer<br/>(max_attempts: 2)"]]
|
||
madv --> radv[["adversary<br/>(max_attempts: 2)"]]
|
||
msec --> rsec[["security-reviewer<br/>(max_attempts: 2)"]]
|
||
mpb --> rpb[["probe<br/>(max_attempts: 2)"]]
|
||
rcr -. "fallback" .-> lfault["lane_fault<br/>(script: PIPELINE-FAULT lane result,<br/>collected by the map)"]
|
||
radv -. "fallback" .-> lfault
|
||
rsec -. "fallback" .-> lfault
|
||
rpb -. "fallback" .-> lfault
|
||
mcr & madv & msec & mpb --> gate["verdict_gate<br/>(script: sentinel regex — deterministic)"]
|
||
gate --> done(["GAUNTLET: PASS | BLOCKED"])
|
||
```
|
||
|
||
## Why a graph
|
||
|
||
The four independent review lanes existed before this agent — as **prompt
|
||
discipline** inside the calling orchestrator: "spawn code-reviewer when the
|
||
change is broad", "🔴 always blocks", "INCONCLUSIVE is never PASS". Prompt
|
||
discipline degrades under context pressure: a lane gets skipped, a verdict
|
||
line gets paraphrased, a missing report reads as "nothing to report". Here
|
||
those rules are *structure*:
|
||
|
||
- **Lane selection floor is deterministic** (`build_items.py`): code-review
|
||
always runs; adversary runs when a spec/plan is present; security runs on
|
||
attack-surface signals (auth/deps/exec paths or diff content) or hardened
|
||
posture; probe runs when consumer-facing surface changed *and* a local-run
|
||
recipe exists. The `select_lanes` LLM can only **widen** the set — a false
|
||
flag never removes a rule-selected lane. `forced_lanes` from the caller
|
||
override everything exactly.
|
||
- **Conditional lanes without dynamic routing**: each lane is a `map` node
|
||
over a 0-or-1-item list — an empty list means the map runs zero branches
|
||
(map-over-nothing), which *is* the skip mechanism. All four maps join at
|
||
the verdict gate on equal-length paths.
|
||
- **The verdict is a regex, not an opinion** (`verdict_gate.py`): a missing
|
||
sentinel is a lane FAILURE, never a pass; any 🔴 in the code-review report
|
||
blocks regardless of its verdict line; `NEEDS-HUMAN` without 🔴 passes but
|
||
is surfaced under *Human attention required*; probe `INCONCLUSIVE` blocks
|
||
with an environment note — it is never treated as PASS or FAIL.
|
||
- **Verdict independence is structural**: lanes run as isolated sub-agents
|
||
with no `teammates:` flag — no cross-lane messaging, by construction.
|
||
- **Failure fails closed, structurally** (`fallback:` routes + `PIPELINE-FAULT`
|
||
markers): every LLM node and lane retries once (`max_attempts: 2`), then a
|
||
fallback fires instead of killing the graph — and every fallback degrades
|
||
toward BLOCKED, never toward a pass. A dead lane becomes a `PIPELINE-FAULT:`
|
||
lane result (`lane_fault.py`) that the gate reports as BLOCKED *naming the
|
||
lane* — distinct from SKIPPED (not selected). A dead `parse` records a fault
|
||
and jumps straight to the gate (`parse_fault.py`). A dead `select_lanes`
|
||
degrades to a deterministic selection (`default_lanes.py`): code-review +
|
||
adversary, plus probe on consumer surface, plus security on auth/deps/exec
|
||
signals or hardened posture, unioned with caller-forced lanes — wider, never
|
||
narrower. A crashed `build_items` records a fault so an all-SKIPPED gate
|
||
still blocks. Fault detection is prefix-anchored — a real review that merely
|
||
*quotes* "PIPELINE-FAULT:" flows to the normal sentinel rules. And the
|
||
`GAUNTLET:` sentinel is always emitted: even a crashed gate prints
|
||
`GAUNTLET: BLOCKED`, never silence.
|
||
|
||
## Sentinels parsed
|
||
|
||
| Lane | Sentinel | Blocks on |
|
||
|------|----------|-----------|
|
||
| code-reviewer | `**Verdict: MERGE-READY \| NEEDS-HUMAN**` | any 🔴 finding; missing sentinel |
|
||
| adversary | `ADVERSARIAL_REVIEW: CONFORMS \| DIVERGES` | DIVERGES; missing sentinel |
|
||
| security-reviewer | `SECURITY_REVIEW: PASS \| FAIL` | FAIL; missing sentinel |
|
||
| probe | `USAGE_PROBE: PASS \| FAIL \| INCONCLUSIVE` | FAIL; INCONCLUSIVE (environment note); missing sentinel |
|
||
|
||
## Spawning it
|
||
|
||
```
|
||
agent__spawn --agent review-gauntlet --prompt "Post-implementation review gate.
|
||
|
||
Project: /abs/path/to/repo
|
||
Diff: main...HEAD (a git range, a ref, or 'worktree' for uncommitted changes)
|
||
Rigor: production Security posture: standard
|
||
|
||
Plan / acceptance criteria:
|
||
<paste the criteria the implementation must satisfy — enables the adversary lane>
|
||
|
||
Local-run recipe / usage suites:
|
||
<how to boot the service locally + where existing suites live — enables the probe lane>
|
||
|
||
Forced lanes: (optional — e.g. 'adversary, probe' to run exactly those)" \
|
||
--variables {"verification_commands": "[\"cargo test --all\", \"cargo clippy -- -D warnings\"]"}
|
||
```
|
||
|
||
Verification commands are NOT part of the prompt. They are the declared
|
||
`verification_commands` graph variable (default `'[]'`; a JSON array of shell
|
||
commands as a string, since agent variables arrive as strings), also settable
|
||
from the CLI:
|
||
|
||
```sh
|
||
coyote -a review-gauntlet --agent-variable project_dir /abs/path/to/repo \
|
||
--agent-variable verification_commands '["cargo test --all"]' "<prompt>"
|
||
```
|
||
|
||
The reply ends with `GAUNTLET: PASS` or `GAUNTLET: BLOCKED`, a lane status
|
||
table, the lane-selection reasons, blockers, attention items, and each lane's
|
||
full report in a collapsible section. On BLOCKED: fix the findings per your
|
||
own findings-handling rules, then spawn a **fresh** gauntlet run. On PASS with
|
||
*Human attention required*: complete the work but carry those items into your
|
||
final report verbatim.
|
||
|
||
## Notes
|
||
|
||
- The caller decides *whether* review is warranted at all (the gauntlet is for
|
||
non-trivial work — that's why code-review is unconditionally on); the
|
||
gauntlet decides *which* of the other lanes apply and what the verdicts mean.
|
||
- Lane sub-agents get generous finite timeouts (2h each; 3h whole-gauntlet)
|
||
and one retry (`max_attempts: 2`). A lane that still dies or times out falls
|
||
back to the `lane_fault` marker — BLOCKED naming the lane, never a silent
|
||
pass.
|
||
- The `verification_commands` variable is forwarded to the adversary lane as a
|
||
structured `inputs:` passthrough on `run_adversary` (a lone `{{…}}` template
|
||
lands the raw value in the child's state) — never through the lane prompt
|
||
and never extracted by `parse`. The adversary's `run_checks` stage executes
|
||
those commands with a shell, which makes the declaration a trust boundary:
|
||
the prompt also carries plan text pasted from the repo under review, so
|
||
commands must never be inferred from it, and the engine merges only the keys
|
||
`parse`'s `output_schema.properties` declares, so an extra
|
||
`verification_commands` key emitted by the LLM is dropped before it reaches
|
||
state.
|
||
Undeclared stays undeclared
|
||
(`'[]'` ⇒ "none declared"); a declaration that is not a JSON array of
|
||
strings executes nothing and records a `PIPELINE-FAULT`, which the
|
||
adversary lane reports as DIVERGES and the gate as BLOCKED.
|
||
- Signals failures degrade gracefully: if git can't compute the diff, lane
|
||
selection falls back to caller context + forced lanes, and the report notes
|
||
it. The auth-path regex deliberately over-fires (`auth(?!or)` matches
|
||
auth/authn/authz/oauth but not "author") — the safe direction, since signals
|
||
only ever ADD the security lane.
|
||
- Requires the `code-reviewer`, `adversary`, `security-reviewer`, and `probe`
|
||
agents to be installed (they ship with Coyote).
|