Dark-Alex-17/kapow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implementing 204 on delete and removing unnecessary steps

Browse Source
This commit is contained in:
Roberto Abdelkader Martínez Pérez
2019-08-23 12:01:51 +02:00
parent 93a3562c04
commit 8752f419b5
3 changed files with 9 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
poc/bin/kapow
+1 -1
View File
@@ -360,7 +360,7 @@ def delete_route(app):
else:
app.change_routes(routes)
app["user_routes"] = routes
return web.Response(status=200, reason="OK")
return web.Response(status=204, reason="No Content")
return _delete_route
spec/test/features/control/delete/list_order.feature
+6 -18
View File
@@ -18,12 +18,8 @@ Feature: Routes auto-ordering after deleting in a Kapow! server.
will be decreased by one.
When I delete the first route inserted
Then I get 200 as response code
And I get "OK" as response reason phrase
When I request a routes listing
Then I get 200 as response code
And I get "OK" as response reason phrase
And I get a list with the following elements:
And I request a routes listing
Then I get a list with the following elements:
"""
[
{
@@ -58,12 +54,8 @@ Feature: Routes auto-ordering after deleting in a Kapow! server.
maintain their relative order and indexes.
When I delete the last route inserted
Then I get 200 as response code
And I get "OK" as response reason phrase
When I request a routes listing
Then I get 200 as response code
And I get "OK" as response reason phrase
And I get a list with the following elements:
And I request a routes listing
Then I get a list with the following elements:
"""
[
{
@@ -99,12 +91,8 @@ Feature: Routes auto-ordering after deleting in a Kapow! server.
following routes will be decreased by one.
When I delete the second route inserted
Then I get 200 as response code
And I get "OK" as response reason phrase
When I request a routes listing
Then I get 200 as response code
And I get "OK" as response reason phrase
And I get a list with the following elements:
And I request a routes listing
Then I get a list with the following elements:
"""
[
{
spec/test/features/control/delete/success.feature
+2 -2
View File
@@ -10,5 +10,5 @@ Feature: Delete routes in Kapow! server.
| GET | /listRootDir | /bin/sh -c | ls -la / \| response /body |
| GET | /listDir/{dirname} | /bin/sh -c | ls -la /request/params/dirname \| response /body |
When I delete the first route
Then I get 200 as response code
And I get "OK" as response reason phrase
Then I get 204 as response code
And I get "No Content" as response reason phrase