From d08f7d4b4e9d7138e45a1294a6ad92f4db0ca712 Mon Sep 17 00:00:00 2001 From: Alex Clarke Date: Wed, 9 Sep 2026 16:31:05 -0600 Subject: [PATCH] test: give the shared IndexerSettings fixture distinct field values minimum_age and retention were both 1, so transposing them in any code that reads both rendered identically and no test could tell the difference. id was also 1, which cannot distinguish a correctly threaded value from a hardcode. Verified by transposing minimum_age and retention in the Sonarr indexer settings UI: that mutation survived the full suite before this change and is now caught by the settings snapshot. --- src/network/servarr_test_utils.rs | 6 +++--- .../indexers/sonarr_indexers_network_tests.rs | 6 +++--- ...tests__indexer_settings_ui_renders_indexer_settings.snap | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/network/servarr_test_utils.rs b/src/network/servarr_test_utils.rs index 23c0872c..d81d96dd 100644 --- a/src/network/servarr_test_utils.rs +++ b/src/network/servarr_test_utils.rs @@ -12,9 +12,9 @@ pub fn diskspace() -> DiskSpace { pub fn indexer_settings() -> IndexerSettings { IndexerSettings { - id: 1, - minimum_age: 1, - retention: 1, + id: 7, + minimum_age: 13, + retention: 21, maximum_size: 12345, rss_sync_interval: 60, } diff --git a/src/network/sonarr_network/indexers/sonarr_indexers_network_tests.rs b/src/network/sonarr_network/indexers/sonarr_indexers_network_tests.rs index 2eeaa8a6..5769e4cf 100644 --- a/src/network/sonarr_network/indexers/sonarr_indexers_network_tests.rs +++ b/src/network/sonarr_network/indexers/sonarr_indexers_network_tests.rs @@ -42,10 +42,10 @@ mod tests { #[tokio::test] async fn test_handle_edit_all_indexer_settings_event() { let indexer_settings_json = json!({ - "id": 1, - "minimumAge": 1, + "id": 7, + "minimumAge": 13, "maximumSize": 12345, - "retention": 1, + "retention": 21, "rssSyncInterval": 60 }); let (mock, app, _server) = MockServarrApi::put() diff --git a/src/ui/sonarr_ui/indexers/snapshots/managarr__ui__sonarr_ui__indexers__indexer_settings_ui__indexer_settings_ui_tests__tests__snapshot_tests__indexer_settings_ui_renders_indexer_settings.snap b/src/ui/sonarr_ui/indexers/snapshots/managarr__ui__sonarr_ui__indexers__indexer_settings_ui__indexer_settings_ui_tests__tests__snapshot_tests__indexer_settings_ui_renders_indexer_settings.snap index 5452cda8..30dcd865 100644 --- a/src/ui/sonarr_ui/indexers/snapshots/managarr__ui__sonarr_ui__indexers__indexer_settings_ui__indexer_settings_ui_tests__tests__snapshot_tests__indexer_settings_ui_renders_indexer_settings.snap +++ b/src/ui/sonarr_ui/indexers/snapshots/managarr__ui__sonarr_ui__indexers__indexer_settings_ui__indexer_settings_ui_tests__tests__snapshot_tests__indexer_settings_ui_renders_indexer_settings.snap @@ -21,10 +21,10 @@ expression: output │ │ │ │ │ ╭────────────────────────────────╮ │ - │ Minimum Age (minutes) ▴▾: │1 │ │ + │ Minimum Age (minutes) ▴▾: │13 │ │ │ ╰────────────────────────────────╯ │ │ ╭────────────────────────────────╮ │ - │ Retention (days) ▴▾: │1 │ │ + │ Retention (days) ▴▾: │21 │ │ │ ╰────────────────────────────────╯ │ │ ╭────────────────────────────────╮ │ │ Maximum Size (MB) ▴▾: │12345 │ │