feat(radarr): make the collection movie overview popup scrollable

A collection movie's overview renders in a popup that does not scroll,
so a long overview overflows with no way to read the rest. The popup now
scrolls.

The popup owns its own ScrollableText, built from the selected collection
movie's overview when it opens and torn down on Esc so a reopened popup
starts at the top. Scrolling mutates only that owned state. The
background renders the Collection record's overview and the movies
table, neither of which carries a scroll offset, so they cannot scroll
along with the popup. The popup also gains the loading and absent
fallbacks the rest of the tree already has.

Give the collection movie fixture an overview distinct from its
collection's, and a multi-paragraph one, so the snapshots can tell the
two records apart and a scrolled popup is distinguishable from an
unscrolled one.
This commit is contained in:
Dark-Alex-17 committed 2026-09-08 22:07:22 -06:00
1 parent b3ce15a564
commit c9244b0459
24 files changed
+913 -66

No files matched your search

@@ -1,14 +1,16 @@
use super::movie_overview_handler::MovieOverviewHandler;
use crate::app::App;
use crate::event::Key;
use crate::handlers::KeyEventHandler;
use crate::handlers::table_handler::{TableHandlingConfig, handle_table};
use crate::matches_key;
use crate::models::servarr_data::radarr::modals::MovieOverviewModal;
use crate::models::servarr_data::radarr::radarr_data::{
ADD_MOVIE_SELECTION_BLOCKS, ActiveRadarrBlock, COLLECTION_DETAILS_BLOCKS,
EDIT_COLLECTION_SELECTION_BLOCKS,
};
use crate::models::stateful_table::StatefulTable;
use crate::models::{BlockSelectionState, Route};
use crate::models::{BlockSelectionState, Route, ScrollableText};
#[cfg(test)]
#[path = "collection_details_handler_tests.rs"]
@@ -21,10 +23,35 @@ pub(super) struct CollectionDetailsHandler<'a, 'b> {
_context: Option<ActiveRadarrBlock>,
}
impl CollectionDetailsHandler<'_, '_> {}
impl CollectionDetailsHandler<'_, '_> {
fn build_movie_overview_modal(&mut self) {
let overview = self
.app
.data
.radarr_data
.collection_movies
.current_selection()
.overview
.clone();
self.app.data.radarr_data.movie_overview_modal = Some(MovieOverviewModal {
overview: ScrollableText::with_string(overview),
});
}
}
impl<'a, 'b> KeyEventHandler<'a, 'b, ActiveRadarrBlock> for CollectionDetailsHandler<'a, 'b> {
fn handle(&mut self) {
if MovieOverviewHandler::accepts(self.active_radarr_block) {
return MovieOverviewHandler::new(
self.key,
self.app,
self.active_radarr_block,
self._context,
)
.handle();
}
let collection_movies_table_handling_config =
TableHandlingConfig::new(ActiveRadarrBlock::CollectionDetails.into());
@@ -98,6 +125,7 @@ impl<'a, 'b> KeyEventHandler<'a, 'b, ActiveRadarrBlock> for CollectionDetailsHan
.iter()
.any(|movie| movie.tmdb_id == tmdb_id)
{
self.build_movie_overview_modal();
self
.app
.push_navigation_stack(ActiveRadarrBlock::ViewMovieOverview.into());
@@ -117,13 +145,9 @@ impl<'a, 'b> KeyEventHandler<'a, 'b, ActiveRadarrBlock> for CollectionDetailsHan
}
fn handle_esc(&mut self) {
match self.active_radarr_block {
ActiveRadarrBlock::CollectionDetails => {
self.app.data.radarr_data.collection_movies = StatefulTable::default();
self.app.pop_navigation_stack();
}
ActiveRadarrBlock::ViewMovieOverview => self.app.pop_navigation_stack(),
_ => (),
if self.active_radarr_block == ActiveRadarrBlock::CollectionDetails {
self.app.data.radarr_data.collection_movies = StatefulTable::default();
self.app.pop_navigation_stack();
}
}