Dark-Alex-17/managarr
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(readarr): stop appending stray colons to the edition overview

Browse Source 
Every line of the edition details popup was parsed as a label and a value,
so a line carrying no colon had one appended to it. A multi-line overview
therefore rendered with a spurious colon at the end of each continuation
line, and Goodreads sourced descriptions, which use CRLF, turned their
blank lines into a lone colon.

Split each line on the first colon only, leave a line without one
unlabelled, and trim the trailing carriage return so a CRLF blank line
renders as a real paragraph break.

Building the line is now a named function so its branches can be asserted
directly. Rendered text discards the carriage return, so a snapshot alone
cannot tell the trimming apart from leaving it in place.

A continuation line that happens to contain a colon is still styled as a
label. Telling those apart needs the details to be built as styled lines
rather than flattened to text and parsed back.
This commit is contained in:
Dark-Alex-17 committed 2026-09-03 13:20:21 -06:00
1 parent 61a18cb222
commit a311e2b895
7 files changed
+103 -35
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/ui/readarr_ui/library/snapshots/managarr__ui__readarr_ui__library__book_details_ui__book_details_ui_tests__tests__snapshot_tests__book_details_ui_renders_edition_details_over_book_details.snap
+3 -3
View File
@@ -19,11 +19,11 @@ expression: output
│ │ASIN: B0043RSJ9S │ │
│ │Ratings: 4.5 (1000 votes) │ │
│ │Monitored: true │ │
│ │Overview: A test edition overview. │ │
│ │ │ │
│ │ │ │
│ │Overview: original cover of ISBN 075640407X │ │
│ │ │ │
│ │My name is Kvothe, pronounced nearly the same as "quothe." │ │
│ │ │ │
│ │The Adem call me Maedre: which means The Flame. │ │
│ │ │ │
│ │ │ │
│ │ │ │
src/ui/readarr_ui/library/snapshots/managarr__ui__readarr_ui__library__edition_details_ui__edition_details_ui_tests__tests__snapshot_tests__edition_details_ui_renders.snap
+3 -3
View File
@@ -19,11 +19,11 @@ expression: output
│ASIN: B0043RSJ9S │
│Ratings: 4.5 (1000 votes) │
│Monitored: true │
│Overview: A test edition overview. │
│ │
│ │
│Overview: original cover of ISBN 075640407X │
│ │
│My name is Kvothe, pronounced nearly the same as "quothe." │
│ │
│The Adem call me Maedre: which means The Flame. │
│ │
│ │
│ │
src/ui/readarr_ui/library/snapshots/managarr__ui__readarr_ui__library__edition_details_ui__edition_details_ui_tests__tests__snapshot_tests__edition_details_ui_renders_scrolled.snap
+3 -3
View File
@@ -17,11 +17,11 @@ expression: output
│ASIN: B0043RSJ9S │
│Ratings: 4.5 (1000 votes) │
│Monitored: true │
│Overview: A test edition overview. │
│ │
│ │
│Overview: original cover of ISBN 075640407X │
│ │
│My name is Kvothe, pronounced nearly the same as "quothe." │
│ │
│The Adem call me Maedre: which means The Flame. │
│ │
│ │
│ │
src/ui/readarr_ui/library/snapshots/managarr__ui__readarr_ui__library__edition_details_ui__edition_details_ui_tests__tests__snapshot_tests__edition_details_ui_renders_with_zero_editions.snap
+3 -3
View File
@@ -19,11 +19,11 @@ expression: output
│ASIN: B0043RSJ9S │
│Ratings: 4.5 (1000 votes) │
│Monitored: true │
│Overview: A test edition overview. │
│ │
│ │
│Overview: original cover of ISBN 075640407X │
│ │
│My name is Kvothe, pronounced nearly the same as "quothe." │
│ │
│The Adem call me Maedre: which means The Flame. │
│ │
│ │
│ │