From 057ff0fef1b09cb90a6906a4544114f7ec29652b Mon Sep 17 00:00:00 2001 From: Alex Clarke Date: Mon, 16 Dec 2024 21:09:24 -0700 Subject: [PATCH 1/3] Fixed a bug in the release pipeline that created a conflict between the tag and the actual code --- .github/workflows/release.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9ddb641..a87674a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -229,6 +229,12 @@ jobs: echo "$changelog" > changelog.md echo "changelog_body=$(cat changelog.md)" >> $GITHUB_ENV + - name: Push changes + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + git push origin --follow-tags + - name: Create a GitHub Release uses: softprops/action-gh-release@v1 env: @@ -265,12 +271,6 @@ jobs: draft: false prerelease: false - - name: Push changes - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - git push origin --follow-tags - - name: Upload artifacts uses: actions/upload-artifact@v3 with: From df0811985dd09c4f5e5e9fe106745884fa1b11ec Mon Sep 17 00:00:00 2001 From: Alex Clarke Date: Tue, 17 Dec 2024 12:15:36 -0700 Subject: [PATCH 2/3] Fixed a bug in the release flow that published the docker image before the version bump --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a87674a..c546cc6 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -278,7 +278,7 @@ jobs: path: artifacts publish-docker-image: - needs: [build-release-artifacts] + needs: [publish-github-release] name: Publishing Docker image to Docker Hub runs-on: ubuntu-latest steps: From 3ecaf04eb4226a4872c5e0fe13405d93f0acb5f3 Mon Sep 17 00:00:00 2001 From: Alex Clarke Date: Tue, 17 Dec 2024 12:40:13 -0700 Subject: [PATCH 3/3] fix: Missing tagged version of docker builds in release flow --- .github/workflows/release.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c546cc6..92a6fc0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -288,6 +288,11 @@ jobs: name: artifacts path: artifacts + - name: Set version variable + run: | + version="$(cat artifacts/release-version)" + echo "version=$version" >> $GITHUB_ENV + - name: Validate release environment variables run: | echo "Release version: ${{ env.version }}"