fix(sonarr): Pass the series ID alongside all UpdateAndScan events when publishing to the networking channel

This commit is contained in:
2024-12-18 01:40:47 -07:00
parent 33249f509f
commit 7e36ad4e8a
7 changed files with 15 additions and 41 deletions
+1 -1
View File
@@ -71,7 +71,7 @@ impl<'a, 'b> CliCommandHandler<'a, 'b, SonarrRefreshCommand>
SonarrRefreshCommand::Series { series_id } => { SonarrRefreshCommand::Series { series_id } => {
let resp = self let resp = self
.network .network
.handle_network_event(SonarrEvent::UpdateAndScanSeries(Some(series_id)).into()) .handle_network_event(SonarrEvent::UpdateAndScanSeries(series_id).into())
.await?; .await?;
serde_json::to_string_pretty(&resp)? serde_json::to_string_pretty(&resp)?
} }
@@ -119,7 +119,7 @@ mod tests {
mock_network mock_network
.expect_handle_network_event() .expect_handle_network_event()
.with(eq::<NetworkEvent>( .with(eq::<NetworkEvent>(
SonarrEvent::UpdateAndScanSeries(Some(expected_series_id)).into(), SonarrEvent::UpdateAndScanSeries(expected_series_id).into(),
)) ))
.times(1) .times(1)
.returning(|_| { .returning(|_| {
+1 -1
View File
@@ -571,7 +571,7 @@ mod tests {
mock_network mock_network
.expect_handle_network_event() .expect_handle_network_event()
.with(eq::<NetworkEvent>( .with(eq::<NetworkEvent>(
SonarrEvent::UpdateAndScanSeries(Some(expected_series_id)).into(), SonarrEvent::UpdateAndScanSeries(expected_series_id).into(),
)) ))
.times(1) .times(1)
.returning(|_| { .returning(|_| {
@@ -195,7 +195,7 @@ impl<'a, 'b> KeyEventHandler<'a, 'b, ActiveSonarrBlock> for SeriesDetailsHandler
ActiveSonarrBlock::UpdateAndScanSeriesPrompt => { ActiveSonarrBlock::UpdateAndScanSeriesPrompt => {
if self.app.data.sonarr_data.prompt_confirm { if self.app.data.sonarr_data.prompt_confirm {
self.app.data.sonarr_data.prompt_confirm_action = self.app.data.sonarr_data.prompt_confirm_action =
Some(SonarrEvent::UpdateAndScanSeries(None)); Some(SonarrEvent::UpdateAndScanSeries(self.extract_series_id()));
} }
self.app.pop_navigation_stack(); self.app.pop_navigation_stack();
@@ -328,7 +328,7 @@ impl<'a, 'b> KeyEventHandler<'a, 'b, ActiveSonarrBlock> for SeriesDetailsHandler
ActiveSonarrBlock::UpdateAndScanSeriesPrompt => { ActiveSonarrBlock::UpdateAndScanSeriesPrompt => {
if self.app.data.sonarr_data.prompt_confirm { if self.app.data.sonarr_data.prompt_confirm {
self.app.data.sonarr_data.prompt_confirm_action = self.app.data.sonarr_data.prompt_confirm_action =
Some(SonarrEvent::UpdateAndScanSeries(None)); Some(SonarrEvent::UpdateAndScanSeries(self.extract_series_id()));
} }
self.app.pop_navigation_stack(); self.app.pop_navigation_stack();
@@ -187,7 +187,7 @@ mod tests {
)] )]
#[case( #[case(
ActiveSonarrBlock::UpdateAndScanSeriesPrompt, ActiveSonarrBlock::UpdateAndScanSeriesPrompt,
SonarrEvent::UpdateAndScanSeries(None) SonarrEvent::UpdateAndScanSeries(1)
)] )]
fn test_series_details_prompt_confirm_submit( fn test_series_details_prompt_confirm_submit(
#[case] prompt_block: ActiveSonarrBlock, #[case] prompt_block: ActiveSonarrBlock,
@@ -572,7 +572,7 @@ mod tests {
)] )]
#[case( #[case(
ActiveSonarrBlock::UpdateAndScanSeriesPrompt, ActiveSonarrBlock::UpdateAndScanSeriesPrompt,
SonarrEvent::UpdateAndScanSeries(None) SonarrEvent::UpdateAndScanSeries(1)
)] )]
fn test_series_details_prompt_confirm_confirm_key( fn test_series_details_prompt_confirm_confirm_key(
#[case] prompt_block: ActiveSonarrBlock, #[case] prompt_block: ActiveSonarrBlock,
+5 -6
View File
@@ -92,7 +92,7 @@ pub enum SonarrEvent {
TriggerAutomaticSeasonSearch((i64, i64)), TriggerAutomaticSeasonSearch((i64, i64)),
TriggerAutomaticSeriesSearch(i64), TriggerAutomaticSeriesSearch(i64),
UpdateAllSeries, UpdateAllSeries,
UpdateAndScanSeries(Option<i64>), UpdateAndScanSeries(i64),
UpdateDownloads, UpdateDownloads,
} }
@@ -2257,13 +2257,12 @@ impl<'a, 'b> Network<'a, 'b> {
.await .await
} }
async fn update_and_scan_series(&mut self, series_id: Option<i64>) -> Result<Value> { async fn update_and_scan_series(&mut self, series_id: i64) -> Result<Value> {
let (id, _) = self.extract_series_id(series_id).await; let event = SonarrEvent::UpdateAndScanSeries(series_id);
let event = SonarrEvent::UpdateAndScanSeries(None); info!("Updating and scanning series with ID: {series_id}");
info!("Updating and scanning series with ID: {id}");
let body = SonarrCommandBody { let body = SonarrCommandBody {
name: "RefreshSeries".to_owned(), name: "RefreshSeries".to_owned(),
series_id: Some(id), series_id: Some(series_id),
..SonarrCommandBody::default() ..SonarrCommandBody::default()
}; };
+3 -28
View File
@@ -197,7 +197,7 @@ mod test {
SonarrEvent::TriggerAutomaticSeasonSearch((0, 0)), SonarrEvent::TriggerAutomaticSeasonSearch((0, 0)),
SonarrEvent::TriggerAutomaticSeriesSearch(0), SonarrEvent::TriggerAutomaticSeriesSearch(0),
SonarrEvent::UpdateAllSeries, SonarrEvent::UpdateAllSeries,
SonarrEvent::UpdateAndScanSeries(None), SonarrEvent::UpdateAndScanSeries(0),
SonarrEvent::UpdateDownloads SonarrEvent::UpdateDownloads
)] )]
event: SonarrEvent, event: SonarrEvent,
@@ -5241,7 +5241,7 @@ mod test {
})), })),
Some(json!({})), Some(json!({})),
None, None,
SonarrEvent::UpdateAndScanSeries(None), SonarrEvent::UpdateAndScanSeries(1),
None, None,
None, None,
) )
@@ -5256,32 +5256,7 @@ mod test {
let mut network = Network::new(&app_arc, CancellationToken::new(), Client::new()); let mut network = Network::new(&app_arc, CancellationToken::new(), Client::new());
assert!(network assert!(network
.handle_sonarr_event(SonarrEvent::UpdateAndScanSeries(None)) .handle_sonarr_event(SonarrEvent::UpdateAndScanSeries(1))
.await
.is_ok());
async_server.assert_async().await;
}
#[tokio::test]
async fn test_handle_update_and_scan_series_event_uses_provied_series_id() {
let (async_server, app_arc, _server) = mock_servarr_api(
RequestMethod::Post,
Some(json!({
"name": "RefreshSeries",
"seriesId": 1
})),
Some(json!({})),
None,
SonarrEvent::UpdateAndScanSeries(Some(1)),
None,
None,
)
.await;
let mut network = Network::new(&app_arc, CancellationToken::new(), Client::new());
assert!(network
.handle_sonarr_event(SonarrEvent::UpdateAndScanSeries(Some(1)))
.await .await
.is_ok()); .is_ok());