diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c7e4e28..79e06a0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -48,51 +48,51 @@ jobs: - name: cargo test --locked run: cargo test --locked --all-features --all-targets - minimal-versions: - # This action chooses the oldest version of the dependencies permitted by Cargo.toml to ensure - # that this crate is compatible with the minimal version that this crate and its dependencies - # require. This will pickup issues where this create relies on functionality that was introduced - # later than the actual version specified (e.g., when we choose just a major version, but a - # method was added after this version). - # - # This particular check can be difficult to get to succeed as often transitive dependencies may - # be incorrectly specified (e.g., a dependency specifies 1.0 but really requires 1.1.5). There - # is an alternative flag available -Zdirect-minimal-versions that uses the minimal versions for - # direct dependencies of this crate, while selecting the maximal versions for the transitive - # dependencies. Alternatively, you can add a line in your Cargo.toml to artificially increase - # the minimal dependency, which you do with e.g.: - # ```toml - # # for minimal-versions - # [target.'cfg(any())'.dependencies] - # openssl = { version = "0.10.55", optional = true } # needed to allow foo to build with -Zminimal-versions - # ``` - # The optional = true is necessary in case that dependency isn't otherwise transitively required - # by your library, and the target bit is so that this dependency edge never actually affects - # Cargo build order. See also - # https://github.com/jonhoo/fantoccini/blob/fde336472b712bc7ebf5b4e772023a7ba71b2262/Cargo.toml#L47-L49. - # This action is run on ubuntu with the stable toolchain, as it is not expected to fail - runs-on: ubuntu-latest - name: ubuntu / stable / minimal-versions - steps: - - uses: actions/checkout@v4 + # minimal-versions: + # # This action chooses the oldest version of the dependencies permitted by Cargo.toml to ensure + # # that this crate is compatible with the minimal version that this crate and its dependencies + # # require. This will pickup issues where this create relies on functionality that was introduced + # # later than the actual version specified (e.g., when we choose just a major version, but a + # # method was added after this version). + # # + # # This particular check can be difficult to get to succeed as often transitive dependencies may + # # be incorrectly specified (e.g., a dependency specifies 1.0 but really requires 1.1.5). There + # # is an alternative flag available -Zdirect-minimal-versions that uses the minimal versions for + # # direct dependencies of this crate, while selecting the maximal versions for the transitive + # # dependencies. Alternatively, you can add a line in your Cargo.toml to artificially increase + # # the minimal dependency, which you do with e.g.: + # # ```toml + # # # for minimal-versions + # # [target.'cfg(any())'.dependencies] + # # openssl = { version = "0.10.55", optional = true } # needed to allow foo to build with -Zminimal-versions + # # ``` + # # The optional = true is necessary in case that dependency isn't otherwise transitively required + # # by your library, and the target bit is so that this dependency edge never actually affects + # # Cargo build order. See also + # # https://github.com/jonhoo/fantoccini/blob/fde336472b712bc7ebf5b4e772023a7ba71b2262/Cargo.toml#L47-L49. + # # This action is run on ubuntu with the stable toolchain, as it is not expected to fail + # runs-on: ubuntu-latest + # name: ubuntu / stable / minimal-versions + # steps: + # - uses: actions/checkout@v4 - - name: Install Rust stable - uses: dtolnay/rust-toolchain@stable + # - name: Install Rust stable + # uses: dtolnay/rust-toolchain@stable - - name: Install nightly for -Zdirect-minimal-versions - uses: dtolnay/rust-toolchain@nightly + # - name: Install nightly for -Zdirect-minimal-versions + # uses: dtolnay/rust-toolchain@nightly - - name: rustup default stable - run: rustup default stable + # - name: rustup default stable + # run: rustup default stable - - name: cargo update -Zdirect-minimal-versions - run: cargo +nightly update -Zdirect-minimal-versions + # - name: cargo update -Zdirect-minimal-versions + # run: cargo +nightly update -Zdirect-minimal-versions - - name: cargo test - run: cargo test --locked --all-features --all-targets + # - name: cargo test + # run: cargo test --locked --all-features --all-targets - - name: Cache Cargo dependencies - uses: Swatinem/rust-cache@v2 + # - name: Cache Cargo dependencies + # uses: Swatinem/rust-cache@v2 os-check: # run cargo test on mac and windows