test: give the delete flags distinct values where params are asserted

The delete params tests set the delete files flag and the list exclusion flag both true, so swapping the two fields in the params builder produced identical params and no test noticed. The tests that assert a reset still set both true, since that is what proves both flags are cleared.
This commit is contained in:
Dark-Alex-17 committed 2026-09-10 01:04:07 -06:00
1 parent 5fa521ba7f
commit 1a5e5c3145
4 files changed
+24 -24

No files matched your search

@@ -127,7 +127,7 @@ mod tests {
app.push_navigation_stack(ActiveLidarrBlock::ArtistDetails.into());
app.push_navigation_stack(ActiveLidarrBlock::DeleteAlbumPrompt.into());
app.data.lidarr_data.prompt_confirm = true;
app.data.lidarr_data.delete_files = true;
app.data.lidarr_data.delete_files = false;
app.data.lidarr_data.add_import_list_exclusion = true;
app
.data
@@ -136,7 +136,7 @@ mod tests {
.set_items(vec![Album::default()]);
let expected_delete_album_params = DeleteParams {
id: 0,
delete_files: true,
delete_files: false,
add_import_list_exclusion: true,
};
app.data.lidarr_data.selected_block = BlockSelectionState::new(DELETE_ALBUM_SELECTION_BLOCKS);
@@ -275,7 +275,7 @@ mod tests {
app.push_navigation_stack(ActiveLidarrBlock::ArtistDetails.into());
app.push_navigation_stack(ActiveLidarrBlock::DeleteAlbumPrompt.into());
app.data.lidarr_data.delete_files = true;
app.data.lidarr_data.add_import_list_exclusion = true;
app.data.lidarr_data.add_import_list_exclusion = false;
app
.data
.lidarr_data
@@ -284,7 +284,7 @@ mod tests {
let expected_delete_album_params = DeleteParams {
id: 0,
delete_files: true,
add_import_list_exclusion: true,
add_import_list_exclusion: false,
};
app.data.lidarr_data.selected_block = BlockSelectionState::new(DELETE_ALBUM_SELECTION_BLOCKS);
app
@@ -352,11 +352,11 @@ mod tests {
.albums
.set_items(vec![Album::default()]);
app.data.lidarr_data.delete_files = true;
app.data.lidarr_data.add_import_list_exclusion = true;
app.data.lidarr_data.add_import_list_exclusion = false;
let expected_delete_album_params = DeleteParams {
id: 0,
delete_files: true,
add_import_list_exclusion: true,
add_import_list_exclusion: false,
};
let delete_album_params = DeleteAlbumHandler::new(
@@ -130,7 +130,7 @@ mod tests {
app.push_navigation_stack(ActiveLidarrBlock::Artists.into());
app.push_navigation_stack(ActiveLidarrBlock::DeleteArtistPrompt.into());
app.data.lidarr_data.prompt_confirm = true;
app.data.lidarr_data.delete_files = true;
app.data.lidarr_data.delete_files = false;
app.data.lidarr_data.add_import_list_exclusion = true;
app
.data
@@ -139,7 +139,7 @@ mod tests {
.set_items(vec![Artist::default()]);
let expected_delete_artist_params = DeleteParams {
id: 0,
delete_files: true,
delete_files: false,
add_import_list_exclusion: true,
};
app.data.lidarr_data.selected_block =
@@ -280,7 +280,7 @@ mod tests {
app.push_navigation_stack(ActiveLidarrBlock::Artists.into());
app.push_navigation_stack(ActiveLidarrBlock::DeleteArtistPrompt.into());
app.data.lidarr_data.delete_files = true;
app.data.lidarr_data.add_import_list_exclusion = true;
app.data.lidarr_data.add_import_list_exclusion = false;
app
.data
.lidarr_data
@@ -289,7 +289,7 @@ mod tests {
let expected_delete_artist_params = DeleteParams {
id: 0,
delete_files: true,
add_import_list_exclusion: true,
add_import_list_exclusion: false,
};
app.data.lidarr_data.selected_block =
BlockSelectionState::new(DELETE_ARTIST_SELECTION_BLOCKS);
@@ -358,11 +358,11 @@ mod tests {
.artists
.set_items(vec![Artist::default()]);
app.data.lidarr_data.delete_files = true;
app.data.lidarr_data.add_import_list_exclusion = true;
app.data.lidarr_data.add_import_list_exclusion = false;
let expected_delete_artist_params = DeleteParams {
id: 0,
delete_files: true,
add_import_list_exclusion: true,
add_import_list_exclusion: false,
};
let delete_artist_params = DeleteArtistHandler::new(
@@ -126,7 +126,7 @@ mod tests {
let mut app = App::test_default();
let expected_delete_movie_params = DeleteMovieParams {
id: 1,
delete_movie_files: true,
delete_movie_files: false,
add_list_exclusion: true,
};
app.push_navigation_stack(ActiveRadarrBlock::Movies.into());
@@ -138,7 +138,7 @@ mod tests {
.set_items(vec![Movie { id: 999, ..movie() }, movie()]);
app.data.radarr_data.movies.select_index(Some(1));
app.data.radarr_data.prompt_confirm = true;
app.data.radarr_data.delete_movie_files = true;
app.data.radarr_data.delete_movie_files = false;
app.data.radarr_data.add_list_exclusion = true;
app.data.radarr_data.selected_block = BlockSelectionState::new(DELETE_MOVIE_SELECTION_BLOCKS);
app
@@ -276,7 +276,7 @@ mod tests {
let expected_delete_movie_params = DeleteMovieParams {
id: 1,
delete_movie_files: true,
add_list_exclusion: true,
add_list_exclusion: false,
};
app.push_navigation_stack(ActiveRadarrBlock::Movies.into());
app.push_navigation_stack(ActiveRadarrBlock::DeleteMoviePrompt.into());
@@ -287,7 +287,7 @@ mod tests {
.set_items(vec![Movie { id: 999, ..movie() }, movie()]);
app.data.radarr_data.movies.select_index(Some(1));
app.data.radarr_data.delete_movie_files = true;
app.data.radarr_data.add_list_exclusion = true;
app.data.radarr_data.add_list_exclusion = false;
app.data.radarr_data.selected_block = BlockSelectionState::new(DELETE_MOVIE_SELECTION_BLOCKS);
app
.data
@@ -355,11 +355,11 @@ mod tests {
.set_items(vec![Movie { id: 999, ..movie() }, movie()]);
app.data.radarr_data.movies.select_index(Some(1));
app.data.radarr_data.delete_movie_files = true;
app.data.radarr_data.add_list_exclusion = true;
app.data.radarr_data.add_list_exclusion = false;
let expected_delete_movie_params = DeleteMovieParams {
id: 1,
delete_movie_files: true,
add_list_exclusion: true,
add_list_exclusion: false,
};
let delete_movie_params = DeleteMovieHandler::new(
@@ -131,7 +131,7 @@ mod tests {
app.push_navigation_stack(ActiveSonarrBlock::Series.into());
app.push_navigation_stack(ActiveSonarrBlock::DeleteSeriesPrompt.into());
app.data.sonarr_data.prompt_confirm = true;
app.data.sonarr_data.delete_series_files = true;
app.data.sonarr_data.delete_series_files = false;
app.data.sonarr_data.add_list_exclusion = true;
app.data.sonarr_data.series.set_items(vec![
Series {
@@ -143,7 +143,7 @@ mod tests {
app.data.sonarr_data.series.select_index(Some(1));
let expected_delete_series_params = DeleteSeriesParams {
id: 1,
delete_series_files: true,
delete_series_files: false,
add_list_exclusion: true,
};
app.data.sonarr_data.selected_block =
@@ -284,7 +284,7 @@ mod tests {
app.push_navigation_stack(ActiveSonarrBlock::Series.into());
app.push_navigation_stack(ActiveSonarrBlock::DeleteSeriesPrompt.into());
app.data.sonarr_data.delete_series_files = true;
app.data.sonarr_data.add_list_exclusion = true;
app.data.sonarr_data.add_list_exclusion = false;
app.data.sonarr_data.series.set_items(vec![
Series {
id: 999,
@@ -296,7 +296,7 @@ mod tests {
let expected_delete_series_params = DeleteSeriesParams {
id: 1,
delete_series_files: true,
add_list_exclusion: true,
add_list_exclusion: false,
};
app.data.sonarr_data.selected_block =
BlockSelectionState::new(DELETE_SERIES_SELECTION_BLOCKS);
@@ -368,11 +368,11 @@ mod tests {
]);
app.data.sonarr_data.series.select_index(Some(1));
app.data.sonarr_data.delete_series_files = true;
app.data.sonarr_data.add_list_exclusion = true;
app.data.sonarr_data.add_list_exclusion = false;
let expected_delete_series_params = DeleteSeriesParams {
id: 1,
delete_series_files: true,
add_list_exclusion: true,
add_list_exclusion: false,
};
let delete_series_params = DeleteSeriesHandler::new(