feat(readarr): handle key events for the authors library table

Add LibraryHandler, which owns the authors table and its sort, search,
and filter overlays through TableHandlingConfig, along with the add,
edit, toggle monitoring, update all, and refresh key actions and the
delete prompt. Dispatch into it from ReadarrHandler and add the main tab
left and right movement helper.

authors_sorting_options offers eight sorts: name, status, quality
profile, metadata profile, books, size, monitored, and tags. It omits
the type and tracks sorts that the artists table has. GET /author never
returns authorType, so that column would be empty on every row, and
author statistics carry no track count.

Also cover the Readarr arm of handle_events, which was previously
unreachable from any test: neutering the arm entirely left the suite
green.
This commit is contained in:
Dark-Alex-17 committed 2026-09-02 16:57:47 -06:00
1 parent d6deb6eea2
commit 06e2d7841e
5 files changed
+1458 -2

No files matched your search

@@ -3,8 +3,9 @@ mod tests {
use crate::app::App;
use crate::app::key_binding::DEFAULT_KEYBINDINGS;
use crate::handlers::KeyEventHandler;
use crate::handlers::readarr_handlers::ReadarrHandler;
use crate::handlers::readarr_handlers::{ReadarrHandler, handle_change_tab_left_right_keys};
use crate::models::servarr_data::readarr::readarr_data::ActiveReadarrBlock;
use crate::{assert_navigation_pushed, test_handler_delegation};
use pretty_assertions::assert_eq;
use rstest::rstest;
use strum::IntoEnumIterator;
@@ -49,4 +50,130 @@ mod tests {
assert!(ReadarrHandler::accepts(readarr_block));
}
}
#[rstest]
#[case(0, ActiveReadarrBlock::System, ActiveReadarrBlock::Downloads)]
#[case(1, ActiveReadarrBlock::Authors, ActiveReadarrBlock::Blocklist)]
#[case(2, ActiveReadarrBlock::Downloads, ActiveReadarrBlock::History)]
#[case(3, ActiveReadarrBlock::Blocklist, ActiveReadarrBlock::RootFolders)]
#[case(4, ActiveReadarrBlock::History, ActiveReadarrBlock::Indexers)]
#[case(5, ActiveReadarrBlock::RootFolders, ActiveReadarrBlock::System)]
#[case(6, ActiveReadarrBlock::Indexers, ActiveReadarrBlock::Authors)]
fn test_readarr_handler_change_tab_left_right_keys(
#[case] index: usize,
#[case] left_block: ActiveReadarrBlock,
#[case] right_block: ActiveReadarrBlock,
) {
let mut app = App::test_default();
app.data.readarr_data.main_tabs.set_index(index);
handle_change_tab_left_right_keys(&mut app, DEFAULT_KEYBINDINGS.left.key);
assert_eq!(
app.data.readarr_data.main_tabs.get_active_route(),
left_block.into()
);
assert_navigation_pushed!(app, left_block.into());
app.data.readarr_data.main_tabs.set_index(index);
handle_change_tab_left_right_keys(&mut app, DEFAULT_KEYBINDINGS.right.key);
assert_eq!(
app.data.readarr_data.main_tabs.get_active_route(),
right_block.into()
);
assert_navigation_pushed!(app, right_block.into());
}
#[rstest]
#[case(0, ActiveReadarrBlock::System, ActiveReadarrBlock::Downloads)]
#[case(1, ActiveReadarrBlock::Authors, ActiveReadarrBlock::Blocklist)]
#[case(2, ActiveReadarrBlock::Downloads, ActiveReadarrBlock::History)]
#[case(3, ActiveReadarrBlock::Blocklist, ActiveReadarrBlock::RootFolders)]
#[case(4, ActiveReadarrBlock::History, ActiveReadarrBlock::Indexers)]
#[case(5, ActiveReadarrBlock::RootFolders, ActiveReadarrBlock::System)]
#[case(6, ActiveReadarrBlock::Indexers, ActiveReadarrBlock::Authors)]
fn test_readarr_handler_change_tab_left_right_keys_alt_navigation(
#[case] index: usize,
#[case] left_block: ActiveReadarrBlock,
#[case] right_block: ActiveReadarrBlock,
) {
let mut app = App::test_default();
app.data.readarr_data.main_tabs.set_index(index);
handle_change_tab_left_right_keys(&mut app, DEFAULT_KEYBINDINGS.left.alt.unwrap());
assert_eq!(
app.data.readarr_data.main_tabs.get_active_route(),
left_block.into()
);
assert_navigation_pushed!(app, left_block.into());
app.data.readarr_data.main_tabs.set_index(index);
handle_change_tab_left_right_keys(&mut app, DEFAULT_KEYBINDINGS.right.alt.unwrap());
assert_eq!(
app.data.readarr_data.main_tabs.get_active_route(),
right_block.into()
);
assert_navigation_pushed!(app, right_block.into());
}
#[rstest]
#[case(0, ActiveReadarrBlock::Authors)]
#[case(1, ActiveReadarrBlock::Downloads)]
#[case(2, ActiveReadarrBlock::Blocklist)]
#[case(3, ActiveReadarrBlock::History)]
#[case(4, ActiveReadarrBlock::RootFolders)]
#[case(5, ActiveReadarrBlock::Indexers)]
#[case(6, ActiveReadarrBlock::System)]
fn test_readarr_handler_change_tab_left_right_keys_alt_navigation_no_op_when_ignoring_quit_key(
#[case] index: usize,
#[case] block: ActiveReadarrBlock,
) {
let mut app = App::test_default();
app.push_navigation_stack(block.into());
app.ignore_special_keys_for_textbox_input = true;
app.data.readarr_data.main_tabs.set_index(index);
handle_change_tab_left_right_keys(&mut app, DEFAULT_KEYBINDINGS.left.alt.unwrap());
assert_eq!(
app.data.readarr_data.main_tabs.get_active_route(),
block.into()
);
assert_eq!(app.get_current_route(), block.into());
app.data.readarr_data.main_tabs.set_index(index);
handle_change_tab_left_right_keys(&mut app, DEFAULT_KEYBINDINGS.right.alt.unwrap());
assert_eq!(
app.data.readarr_data.main_tabs.get_active_route(),
block.into()
);
assert_eq!(app.get_current_route(), block.into());
}
#[rstest]
fn test_delegates_library_blocks_to_library_handler(
#[values(
ActiveReadarrBlock::Authors,
ActiveReadarrBlock::AuthorsSortPrompt,
ActiveReadarrBlock::FilterAuthors,
ActiveReadarrBlock::FilterAuthorsError,
ActiveReadarrBlock::SearchAuthors,
ActiveReadarrBlock::SearchAuthorsError,
ActiveReadarrBlock::UpdateAllAuthorsPrompt
)]
active_readarr_block: ActiveReadarrBlock,
) {
test_handler_delegation!(
ReadarrHandler,
ActiveReadarrBlock::Authors,
active_readarr_block
);
}
}