refactor: several improvements (#132)

- js export expression
- check args regarding run-agent/run-tool

scripts/create-tool.sh

@@ -75,7 +75,7 @@ create_js() {
  * @typedef {Object} Args${properties}
  * @param {Args} args
  */
-exports.run = function run(args) {
+exports.run = function (args) {
   console.log(args);
 }
 EOF

scripts/run-agent.js

@@ -31,10 +31,15 @@ function parseArgv(thisFileName) {
     agentData = process.argv[3];
   }
 
-  if (agentName.endsWith(".js")) {
+  if (agentName && agentName.endsWith(".js")) {
     agentName = agentName.slice(0, -3);
   }
 
+  if (!agentData || !agentFunc || !agentName) {
+    console.log(`Usage: ./run-agent.js <agent-name> <agent-func> <agent-data>`);
+    process.exit(1);
+  }
+
   return [agentName, agentFunc, agentData];
 }
 

scripts/run-agent.py

@@ -32,20 +32,26 @@ def parse_argv(this_file_name):
 
     agent_name = argv[0]
     agent_func = ""
-    agent_data = None
+    agent_data = ""
 
     if agent_name.endswith(this_file_name):
-        agent_name = sys.argv[1]
-        agent_func = sys.argv[2]
-        agent_data = sys.argv[3]
+        if len(sys.argv) > 3:
+            agent_name = sys.argv[1]
+            agent_func = sys.argv[2]
+            agent_data = sys.argv[3]
     else:
-        agent_name = os.path.basename(agent_name)
-        agent_func = sys.argv[1]
-        agent_data = sys.argv[2]
+        if len(sys.argv) > 2:
+            agent_name = os.path.basename(agent_name)
+            agent_func = sys.argv[1]
+            agent_data = sys.argv[2]
 
-    if agent_name.endswith(".py"):
+    if agent_name and agent_name.endswith(".py"):
         agent_name = agent_name[:-3]
 
+    if (not agent_data) or (not agent_func) or (not agent_name):
+        print("Usage: ./run-agent.py <agent-name> <agent-func> <agent-data>", file=sys.stderr)
+        sys.exit(1)   
+
     return agent_name, agent_func, agent_data
 
 

scripts/run-agent.sh

@@ -23,6 +23,9 @@ parse_argv() {
     if [[ "$agent_name" == *.sh ]]; then
         agent_name="${agent_name:0:$((${#agent_name}-3))}"
     fi
+    if [[ -z "$agent_data" ]] || [[ -z "$agent_func" ]] || [[ -z "$agent_name" ]]; then
+        die "usage: ./run-agent.sh <agent-name> <agent-func> <agent-data>"
+    fi
 }
 
 setup_env() {

scripts/run-tool.js

@@ -28,10 +28,15 @@ function parseArgv(thisFileName) {
     toolData = process.argv[2];
   }
 
-  if (toolName.endsWith(".js")) {
+  if (toolName && toolName.endsWith(".js")) {
     toolName = toolName.slice(0, -3);
   }
 
+  if (!toolData || !toolName) {
+    console.log(`Usage: ./run-tools.js <tool-name> <tool-data>`);
+    process.exit(1);
+  }
+
   return [toolName, toolData];
 }
 

scripts/run-tool.py

@@ -31,18 +31,24 @@ def parse_argv(this_file_name):
     argv = sys.argv[:] + [None] * max(0, 3 - len(sys.argv))
 
     tool_name = argv[0]
-    tool_data = None
+    tool_data = ""
 
     if tool_name.endswith(this_file_name):
-        tool_name = argv[1]
-        tool_data = argv[2]
+        if len(sys.argv) > 2:
+            tool_name = argv[1]
+            tool_data = argv[2]
     else:
-        tool_name = os.path.basename(tool_name)
-        tool_data = sys.argv[1]
+        if len(sys.argv) > 1:
+            tool_name = os.path.basename(tool_name)
+            tool_data = sys.argv[1]
 
-    if tool_name.endswith(".py"):
+    if tool_name and tool_name.endswith(".py"):
         tool_name = tool_name[:-3]
 
+    if (not tool_data) or (not tool_name):
+        print("Usage: ./run-tool.py <tool-name> <tool-data>", file=sys.stderr)
+        sys.exit(1)   
+
     return tool_name, tool_data
 
 

scripts/run-tool.sh

@@ -21,6 +21,9 @@ parse_argv() {
     if [[ "$tool_name" == *.sh ]]; then
         tool_name="${tool_name:0:$((${#tool_name}-3))}"
     fi
+    if [[ -z "$tool_data" ]] || [[ -z "$tool_name" ]]; then
+        die "usage: ./run-tool.sh <tool-name> <tool-data>"
+    fi
 }
 
 setup_env() {