Commit Graph

1020 Commits

Author SHA1 Message Date
Héctor Hurtado 6b34047d75 Added gock.IsDone() to route list and remove tests. Remove content type in route remove command. Removed disturbing data for texts. Remove unneeded test in set command. 2019-10-04 13:55:36 +02:00
Héctor Hurtado b93a5a0c98 Fixed error specification of get and set commands in Data API 2019-10-04 13:17:29 +02:00
pancho horrillo a865ade26a Use string concatenation to compose simple expression
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-04 07:28:08 +02:00
pancho horrillo 57d1aabb66 internal/cmd/route.go: replace dummies with calls to client code
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-04 06:46:40 +02:00
pancho horrillo b9bf78abf4 Fix route_add{,_test}.go to use an io.Writer for saving the response
Also add a TODO regarding untested response payload.

Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-04 06:28:17 +02:00
pancho horrillo 219710bb76 Fix documentation comment
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-04 06:04:56 +02:00
pancho horrillo c65d2ac548 Don't set MatchType to json in gock for requests without body 2019-10-03 22:50:42 +02:00
pancho horrillo c01c3db4f9 Fix indentation and drop spurious whitespace 2019-10-03 22:48:21 +02:00
pancho horrillo df96d322fc Don't set Content-Type to application/json in query without body 2019-10-03 22:47:43 +02:00
pancho horrillo 604569c7a3 Add internal/client/route_list{,_test}.go
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-03 22:42:31 +02:00
Roberto Abdelkader Martínez Pérez 6eb213a545 Adjust set and get to send no Content-Type 2019-10-03 20:57:40 +02:00
Roberto Abdelkader Martínez Pérez 2d712d39dc Adjust current implementation to accomodate content-type and test to check it 2019-10-03 20:56:53 +02:00
Roberto Abdelkader Martínez Pérez 4357b1ad20 Implementation of route add 2019-10-03 20:56:40 +02:00
Roberto Abdelkader Martínez Pérez 9f7fc8ce62 Allow user specify Content-Type header 2019-10-03 20:55:11 +02:00
pancho horrillo 013cd4d637 Add internal/client/route_remove{,_test}.go
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-03 18:22:18 +02:00
pancho horrillo 306889c958 Add TODO on closing the connection of the http.Client
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-03 16:52:55 +02:00
pancho horrillo ffa262b2b6 Simplify internal/client/set.go by leveraging internal/http.Request()
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-03 16:52:15 +02:00
Roberto Abdelkader Martínez Pérez b1c2db057c Shorthand functions request with common HTTP methods 2019-10-03 15:06:26 +02:00
Roberto Abdelkader Martínez Pérez 43abacbb2f Linter rules 2019-10-03 15:06:09 +02:00
Roberto Abdelkader Martínez Pérez d854787cc2 Bump Go version to 1.13 2019-10-03 14:27:52 +02:00
Roberto Abdelkader Martínez Pérez 80eea3c886 Documentation and better naming 2019-10-03 14:17:24 +02:00
Roberto Abdelkader Martínez Pérez 681ee3cba8 http becomes an internal package 2019-10-03 14:12:14 +02:00
Roberto Abdelkader Martínez Pérez 0144569f58 Documentation 2019-10-03 14:11:06 +02:00
Roberto Abdelkader Martínez Pérez d259e3b411 Replace implementation with kapow/http/response 2019-10-03 14:11:06 +02:00
Roberto Abdelkader Martínez Pérez 6689ed458c Better names for tests 2019-10-03 14:11:06 +02:00
Roberto Abdelkader Martínez Pérez 62f774e1cf Request module and tests 2019-10-03 14:11:06 +02:00
Roberto Abdelkader Martínez Pérez 8529ee056b Remove unused package 2019-10-03 14:11:06 +02:00
Roberto Abdelkader Martínez Pérez 9ff263a5f9 Update dependencies 2019-10-03 14:11:06 +02:00
pancho horrillo 23128026c7 Rework directory structure
Co-authored-by: Héctor Hurtado <hector.hurtado@bbva.com>
2019-10-03 12:05:53 +02:00
Héctor Hurtado 8b7d1d69e7 Added gock call validation 2019-10-03 10:43:51 +02:00
Héctor Hurtado 332d897927 Added set command fuction to client package 2019-10-03 10:37:29 +02:00
Roberto Abdelkader Martínez Pérez f32beffd33 New function GetReason to get HTTP reason phrase from an http.Request 2019-10-02 16:20:39 +02:00
Roberto Abdelkader Martínez Pérez 3602dc71f2 Code imported from @CesarGallego private repo 2019-10-02 15:49:16 +02:00
Roberto Abdelkader Martínez Pérez e146ec6647 Verbose test output 2019-10-02 15:48:43 +02:00
Roberto Abdelkader Martínez Pérez 9496f977d2 Add new dependencies 2019-10-02 15:48:27 +02:00
pancho horrillo 27cf52467d poc: Drop unused import 2019-09-16 10:24:11 +02:00
pancho horrillo 19bb6320b9 spec: Fix command name start -> server 2019-09-16 09:19:19 +02:00
Roberto Abdelkader Martínez Pérez b7f61aeb63 kapow get streams reponse 2019-09-13 11:18:21 +02:00
pancho horrillo 32d0a00c43 Merge pull request #26 from BBVA/fix/style
Style fixes and minor typos.
2019-09-09 14:45:28 +02:00
pancho horrillo b4b5052149 Revert "Style fix."
This reverts commit 5c72f3a498.

Thanks to @nilp0inter for clarifying this one as well.
2019-09-09 14:40:52 +02:00
pancho horrillo 94135c6ab9 Revert "Style fix."
Thanks to @nilp0inter for pointing out that this was not Basic English.

This reverts commit 0eb51f12ac.
2019-09-09 14:30:07 +02:00
pancho horrillo 567f68b695 Style fix. 2019-09-06 13:55:22 +02:00
pancho horrillo 28c16409a8 Style fix. 2019-09-06 13:55:22 +02:00
pancho horrillo 84f6a89c2d Clarify expression. 2019-09-06 13:55:22 +02:00
pancho horrillo ff0f3aefc5 Style fix. 2019-09-06 13:55:22 +02:00
pancho horrillo 249d0f3e9f Style fix. 2019-09-06 13:55:22 +02:00
pancho horrillo 41d8f39c9a Style fix. 2019-09-06 13:55:22 +02:00
pancho horrillo 5c72f3a498 Style fix. 2019-09-06 13:55:22 +02:00
pancho horrillo 3a545ac7b3 Style fix. 2019-09-06 13:55:22 +02:00
pancho horrillo 0eb51f12ac Style fix. 2019-09-06 13:55:22 +02:00