Normalize internal/client/*_test.go

* Adjust test style for easy reading, by using literals instead of vars
* Move comparison to the `bytes` domain, instead of `string`
* Simplify testing code by using bytes.Buffer directly
* More consistent naming of variables and dummies (HANDLE_{FOO,BAR,BAD})
* Consistent testing style of gock.IsDone()
* Stick to 80-column
This commit is contained in:
pancho horrillo
2019-10-06 09:41:12 +02:00
parent 25409a2cee
commit f98784088d
6 changed files with 78 additions and 92 deletions
+8 -4
View File
@@ -21,15 +21,19 @@ func TestSuccessOnCorrectRoute(t *testing.T) {
Reply(http.StatusCreated).
JSON(map[string]string{})
// TODO: As per the spec¹, the call should return a JSON body with the info of the new route
// We should consider this in the mocked server and in the test
// TODO: As per the spec¹, the call should return a JSON body with the info
// of the newly created route. Should we consider this in the mocked server
// and in the test?
// ¹: https://github.com/BBVA/kapow/tree/master/spec#insert-a-route
err := AddRoute("http://localhost", "/hello", "GET", "", "echo Hello World | kapow set /response/body", nil)
err := AddRoute(
"http://localhost",
"/hello", "GET", "", "echo Hello World | kapow set /response/body", nil)
if err != nil {
t.Errorf("Unexpected error: %s", err)
}
if gock.IsDone() == false {
if !gock.IsDone() {
t.Error("Expected endpoint call not made")
}
}