From bd2bed53d1b3a8c4a40ba9369f8ec8dc619b8a2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9sar=20Gallego=20Rodr=C3=ADguez?= Date: Thu, 10 Oct 2019 16:59:29 +0200 Subject: [PATCH] invalid URL --- internal/server/data/server_test.go | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/internal/server/data/server_test.go b/internal/server/data/server_test.go index d1c6fc4..cd9d6e8 100644 --- a/internal/server/data/server_test.go +++ b/internal/server/data/server_test.go @@ -72,6 +72,28 @@ func TestUpdateResourceNotFoundWhenInvalidHandlerID(t *testing.T) { } } +func TestUpdateResourceBadRequestWhenInvalidUrl(t *testing.T) { + t.Skip("***** WIP ****") + request := httptest.NewRequest(http.MethodPut, "/handlers/HANDLER_YYYYYYYYYYYYYYYY/response/headers", strings.NewReader("value")) + response := httptest.NewRecorder() + handler := mux.NewRouter() + handler.HandleFunc("/handlers/{handler_id}/{resource:.*$}", updateResource). + Methods("PUT") + + getHandlerId = func(id string) (*model.Handler, bool) { + if id == "HANDLER_YYYYYYYYYYYYYYYY" { + return nil, true + } + + return nil, false + } + + handler.ServeHTTP(response, request) + if response.Code != http.StatusBadRequest { + t.Errorf("HTTP Status mismatch. Expected: %d, got: %d", http.StatusBadRequest, response.Code) + } +} + func TestUpdateResourceOkWhenValidHandlerID(t *testing.T) { request := httptest.NewRequest(http.MethodPut, "/handlers/HANDLER_XXXXXXXXXXXX/response/headers/name", strings.NewReader("value")) response := httptest.NewRecorder() @@ -80,13 +102,11 @@ func TestUpdateResourceOkWhenValidHandlerID(t *testing.T) { Methods("PUT") getHandlerId = func(id string) (*model.Handler, bool) { - if id == "HANDLER_YYYYYYYYYYYYYYYY" { - return nil, false - } else if id == "HANDLER_XXXXXXXXXXXX" { + if id == "HANDLER_XXXXXXXXXXXX" { return nil, true } - return nil, true + return nil, false } handler.ServeHTTP(response, request)