Add method ListIDs() to internal/data/Handlers

Co-authored-by: Roberto Abdelkader Martínez Pérez <robertomartinezp@gmail.com>

internal/server/data/state.go

@@ -38,3 +38,12 @@ func (shm *safeHandlerMap) Get(id string) (*model.Handler, bool) {
 	shm.m.RUnlock()
 	return h, ok
 }
+
+func (shm *safeHandlerMap) ListIDs() (ids []string) {
+	shm.m.RLock()
+	defer shm.m.RUnlock()
+	for id := range shm.hs {
+		ids = append(ids, id)
+	}
+	return
+}

internal/server/data/state_test.go

@@ -145,7 +145,7 @@ func TestGetWaitsForTheWriterToFinish(t *testing.T) {
 
 	select {
 	case <-c:
-		t.Error("Handler readed while mutex was acquired")
+		t.Error("Handler read while mutex was acquired")
 	default: // This default prevents the select from being blocking
 	}
 }
@@ -168,3 +168,60 @@ func TestGetNonBlockingReadWithOtherReaders(t *testing.T) {
 		t.Error("Handler couldn't read while mutex was acquired for read")
 	}
 }
+
+func TestListIDsReturnsTheListOfHandlerIDs(t *testing.T) {
+	shm := New()
+	shm.hs["FOO"] = nil
+	shm.hs["BAR"] = nil
+	shm.hs["BAZ"] = nil
+
+	ids := make(map[string]bool)
+	for _, id := range shm.ListIDs() {
+		ids[id] = true
+	}
+
+	_, okFoo := ids["FOO"]
+	_, okBar := ids["BAR"]
+	_, okBaz := ids["BAZ"]
+	if !okFoo || !okBar || !okBaz {
+		t.Error("Some IDs not returned")
+	}
+}
+
+func TestListIDsWaitsForTheWriterToFinish(t *testing.T) {
+	shm := New()
+	shm.Add(&model.Handler{ID: "FOO"})
+
+	shm.m.Lock()
+	defer shm.m.Unlock()
+
+	c := make(chan []string)
+	go func() { c <- shm.ListIDs() }()
+
+	time.Sleep(10 * time.Millisecond)
+
+	select {
+	case <-c:
+		t.Error("Handler read while mutex was acquired")
+	default: // This default prevents the select from being blocking
+	}
+}
+
+func TestListIDsNonBlockingReadWithOtherReaders(t *testing.T) {
+	shm := New()
+	shm.Add(&model.Handler{ID: "FOO"})
+
+	shm.m.RLock()
+	defer shm.m.RUnlock()
+
+	c := make(chan []string)
+	go func() { c <- shm.ListIDs() }()
+
+	time.Sleep(10 * time.Millisecond)
+
+	select {
+	case <-c:
+	default: // This default prevents the select from being blocking
+		t.Error("Handler couldn't read while mutex was acquired for read")
+	}
+}