From 7949ac860ad997b772dd2c8bcdf3e5717fdb7e35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roberto=20Abdelkader=20Mart=C3=ADnez=20P=C3=A9rez?= Date: Wed, 30 Dec 2020 15:41:30 +0100 Subject: [PATCH] chore: Do not try to upload docker images if secrets are undefined (#143) --- .github/workflows/release.yml | 11 +++++++++++ .goreleaser.yml | 2 ++ 2 files changed, 13 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 4147026..876ab31 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,7 +30,13 @@ jobs: RELNOTES="docs/release-notes/RELEASE-${GITHUB_REF#refs/tags/}.md" [[ -f "$RELNOTES" ]] && echo ::set-output name=ARGS::--release-notes $RELNOTES || true + - name: Check credentials + id: docker-credentials + run: | + echo ::set-output name=defined::$(test -n "${{ secrets.DOCKERHUB_USERNAME }}" && echo true || echo false) + - name: Docker Login + if: steps.docker-credentials.outputs.defined == 'true' run: | username="${{ secrets.DOCKERHUB_USERNAME }}" password="${{ secrets.DOCKERHUB_PASSWORD }}" @@ -41,6 +47,7 @@ jobs: args: release --rm-dist ${{ steps.release-notes.outputs.ARGS }} env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Archive binaries as artifacts uses: actions/upload-artifact@v2 with: @@ -48,6 +55,10 @@ jobs: path: | dist/* + - name: Upload Docker images + if: steps.docker-credentials.outputs.defined == 'true' + run: docker image push --all-tags bbvalabsci/kapow + wininstaller: runs-on: ubuntu-20.04 needs: build diff --git a/.goreleaser.yml b/.goreleaser.yml index f472aa1..c088e95 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -54,6 +54,8 @@ dockers: - "bbvalabsci/kapow:{{ .Tag }}" - "bbvalabsci/kapow:v{{ .Major }}" + skip_push: true + release: draft: false prerelease: auto