From 483056ea162c72d52855b6a275d17f7a72c5bea3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Roberto=20Abdelkader=20Mart=C3=ADnez=20P=C3=A9rez?= Date: Wed, 21 Aug 2019 13:11:45 +0200 Subject: [PATCH] Clarification about aiohttp unsafe usage in PoC --- poc/bin/kapow | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/poc/bin/kapow b/poc/bin/kapow index b1717ce..2180c0c 100755 --- a/poc/bin/kapow +++ b/poc/bin/kapow @@ -400,6 +400,16 @@ class InvalidRouteError(Exception): class DynamicApplication(web.Application): + """ + A wrapper around `aiohttp.web.Application` allowing changing routes + dynamically. + + This is not safe as mentioned here: + https://github.com/aio-libs/aiohttp/issues/3238. + + On the other hand this is a PoC anyway... + + """ def change_routes(self, routes): router = UrlDispatcher() try: