internal/client/{get,set}_test.go: send io.Writer() based on []byte

* internal/client/get_test.go:
  - Revert changes when setting the Body of the mock (gock).
  - Revert over-eager line splitting.

* internal/client/set_test.go:
  - Use bytes.NewReader([]byte("200")) instead of strings.NewReader("200")

Thanks to @nilp0inter for the feedback!
This commit is contained in:
pancho horrillo
2019-10-06 11:34:15 +02:00
parent f98784088d
commit 0b056f6cf0
2 changed files with 11 additions and 6 deletions
+9 -3
View File
@@ -1,8 +1,8 @@
package client_test
import (
"bytes"
"net/http"
"strings"
"testing"
gock "gopkg.in/h2non/gock.v1"
@@ -19,7 +19,10 @@ func TestSetDataSuccessOnCorrectRequest(t *testing.T) {
if err := client.SetData(
"http://localhost:8080",
"HANDLER_FOO", "/response/status/code", strings.NewReader("200")); err != nil {
"HANDLER_FOO",
"/response/status/code",
bytes.NewReader([]byte("200")),
); err != nil {
t.Error("Unexpected error")
}
@@ -37,7 +40,10 @@ func TestSetDataErrIfBadHandlerID(t *testing.T) {
if err := client.SetData(
"http://localhost:8080",
"HANDLER_BAD", "/response/status/code", strings.NewReader("200")); err == nil {
"HANDLER_BAD",
"/response/status/code",
bytes.NewReader([]byte("200")),
); err == nil {
t.Error("Expected error not present")
} else if err.Error() != "Not Found" {
t.Errorf(`Error mismatch: expected "Not Found", got %q`, err)