From 046d8ffe7d36a1504f96d465b61c58507b9ffc9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9sar=20Gallego=20Rodr=C3=ADguez?= Date: Wed, 9 Oct 2019 14:18:54 +0200 Subject: [PATCH] linter fixes --- internal/server/control/control.go | 8 ++++---- internal/server/control/control_test.go | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/server/control/control.go b/internal/server/control/control.go index 072a9ce..ec32bf4 100644 --- a/internal/server/control/control.go +++ b/internal/server/control/control.go @@ -31,7 +31,7 @@ var funcRemove func(id string) error func removeRoute(res http.ResponseWriter, req *http.Request) { vars := mux.Vars(req) - id, _ := vars["id"] + id := vars["id"] if err := funcRemove(id); err != nil { res.WriteHeader(http.StatusNotFound) return @@ -42,10 +42,10 @@ func removeRoute(res http.ResponseWriter, req *http.Request) { // user.Routes.List() []model.Route var funcList func() []model.Route = user.Routes.List -func listRoutes(http.ResponseWriter, *http.Request) { +func listRoutes(res http.ResponseWriter, req *http.Request) { funcList() - + res.WriteHeader(http.StatusNotFound) } // user.Routes.Append(r model.Route) model.Route @@ -69,5 +69,5 @@ func addRoute(res http.ResponseWriter, req *http.Request) { res.WriteHeader(http.StatusCreated) res.Header().Set("Content-Type", "application/json") - res.Write(createdBytes) + _, _ = res.Write(createdBytes) } diff --git a/internal/server/control/control_test.go b/internal/server/control/control_test.go index e1cadeb..026c54f 100644 --- a/internal/server/control/control_test.go +++ b/internal/server/control/control_test.go @@ -125,6 +125,7 @@ func TestRemoveRouteReturnsNoContent(t *testing.T) { } } +// FIXME: ListRoutes is a get, no path params, call func TestListRoutesReturnsEmptyList(t *testing.T) { t.Skip("****** WIP ******")