From 02929e0d498ffbed5203dc6c0d7ec690effdd042 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9sar=20Gallego=20Rodr=C3=ADguez?= Date: Wed, 4 Sep 2019 12:31:16 +0200 Subject: [PATCH] Fix Pipenv creation file from unnecesary running of pipenv. Co-authored-by: nilpointer --- Makefile | 2 +- Pipfile | 11 ----------- pkg/banner/banner_test.go | 4 ++-- 3 files changed, 3 insertions(+), 14 deletions(-) delete mode 100644 Pipfile diff --git a/Makefile b/Makefile index 05a2536..41c5a7b 100644 --- a/Makefile +++ b/Makefile @@ -10,7 +10,7 @@ install: test go install github.com/BBVA/kapow/... acceptance: install - pipenv run make -C spec/test + make -C spec/test deps: go install github.com/spf13/cobra diff --git a/Pipfile b/Pipfile deleted file mode 100644 index b723d01..0000000 --- a/Pipfile +++ /dev/null @@ -1,11 +0,0 @@ -[[source]] -name = "pypi" -url = "https://pypi.org/simple" -verify_ssl = true - -[dev-packages] - -[packages] - -[requires] -python_version = "3.7" diff --git a/pkg/banner/banner_test.go b/pkg/banner/banner_test.go index dbd3ddd..9e7b953 100644 --- a/pkg/banner/banner_test.go +++ b/pkg/banner/banner_test.go @@ -3,8 +3,8 @@ package banner import "testing" func TestBanner(t *testing.T) { - ban := Banner() - if ban != "KAPOW!!!" { + ban := Banner("0.0.0") + if ban == "" { t.Errorf("Banner expected KAPOW!!!, but got %v", ban) t.Fail() }