Dark-Alex-17
156f3193a9
code-reviewer verdict.py: finding-verifier now completes "successfully" with fault markers INSIDE its FINDING_VERIFIER_RESULTS payload (parse_fault's `pipeline-fault` sentinel id, verify_fault / verdict_gate crash-guard notes prefixed PIPELINE-FAULT:), which the old "Agent node failed:" prefix check never saw — a dead parse degraded silently to "unverified" with no fault recorded. Detect them, anchored on the sentinel id / note prefix only (never a substring over the report), counted over the raw entry list so duplicate crash-guard ids are not collapsed. Faults lead the attention list uncapped; the display cap of 5 applies to non-fault entries; the "always-human trigger(s) fired" reason fires only when non-fault triggers exist. code-reviewer render.py: CONTRACT comments at the verdict and summary lines review-gauntlet's gate parses; every LLM-influenced value rendered after the summary line (dropped_titles, rigor, bar_provenance, resolved_surfaces, reason) is newline-sanitised so none can forge a second summary line. finding-verifier verdict_gate.py: the outer crash-guard note carries the PIPELINE-FAULT: prefix (the after-retry UNVERIFIABLE path stays unprefixed — model misbehaviour, not infrastructure); README names all three emitters. deep-research: vet_fault's UNVETTED note tells the critic not to request revision solely because the assessment is unavailable (it matched critique's PREPRINT/UNVERIFIED REVISE trigger verbatim, burning the revision budget on an infra fault); vet_fault and critique_fault dedupe repeated faults and preserve accumulated faults on crash via safe_faults(); question_fault keeps its plan-pinned prefix and appends the lane's question identity so distinct dead lanes no longer collapse in combine_findings' dedupe.
71 lines
2.4 KiB
Python
71 lines
2.4 KiB
Python
#!/usr/bin/env python3
|
|
"""Fail-closed marker for a dead research lane of the deep-research graph.
|
|
|
|
Reached ONLY via research_one_question's `fallback:` route inside the
|
|
`research_each_question` map branch (branch-local — a map branch's fallback
|
|
must stay inside the branch subgraph). Grounded in engine behavior: on
|
|
llm-node failure the engine writes "LLM node …failed: <chain>" into
|
|
`finding` via the node's state_updates BEFORE routing to the fallback (on
|
|
success the same key holds the researched findings, which never start with
|
|
the "LLM node" prefix). This node normalizes the failure text into a
|
|
PIPELINE-FAULT finding and the chain ends here — the map collects the fault
|
|
as the lane's `finding`, so one dead research lane never sinks the whole
|
|
map. combine_findings later lifts PIPELINE-FAULT findings into
|
|
`pipeline_faults` so the fault also surfaces in the report's Pipeline notes.
|
|
The question text is part of the fault so distinct dead lanes with identical
|
|
engine failure text do not collapse into one entry there.
|
|
"""
|
|
|
|
import json
|
|
import os
|
|
|
|
MAX_DETAIL_CHARS = 500
|
|
MAX_QUESTION_CHARS = 200
|
|
|
|
|
|
def load_state():
|
|
if path := os.environ.get("GRAPH_STATE_FILE"):
|
|
with open(path) as f:
|
|
return json.load(f)
|
|
return json.loads(os.environ.get("GRAPH_STATE", "{}"))
|
|
|
|
|
|
def fault_finding(question, detail):
|
|
return {
|
|
"finding": (
|
|
"PIPELINE-FAULT: question research failed — finding unavailable — "
|
|
f'{detail} (question: "{question}")'
|
|
)
|
|
}
|
|
|
|
|
|
def question_label(state):
|
|
raw = state.get("question")
|
|
question = raw.strip().replace("\n", " ") if isinstance(raw, str) else ""
|
|
if not question:
|
|
return "(unknown question)"
|
|
if len(question) > MAX_QUESTION_CHARS:
|
|
question = question[: MAX_QUESTION_CHARS - 1] + "…"
|
|
return question
|
|
|
|
|
|
def main():
|
|
state = load_state()
|
|
raw = state.get("finding")
|
|
detail = raw.strip().replace("\n", " ") if isinstance(raw, str) else ""
|
|
if not detail.startswith("LLM node"):
|
|
detail = "the research lane died without recording a failure detail"
|
|
if len(detail) > MAX_DETAIL_CHARS:
|
|
detail = detail[: MAX_DETAIL_CHARS - 1] + "…"
|
|
print(json.dumps(fault_finding(question_label(state), detail)))
|
|
|
|
|
|
try:
|
|
main()
|
|
except Exception as e: # noqa: BLE001 — the fault marker itself must never crash
|
|
print(
|
|
json.dumps(
|
|
fault_finding("(unknown question)", f"fault-marker script error: {e}")
|
|
)
|
|
)
|