Dark-Alex-17
a7744e7f89
An llm node never persists its completion under `output` (the binding is transient), so a map branch without state_updates collected the stale inherited value: deep-research produced `None` findings and finding-verifier errored on its first item because `output` was absent. Both maps now declare an explicit output_key and their branch nodes write it via state_updates. graph.example.yaml's research_subject gets the same named-key pattern and its branch comment describes it. Design: plans/map-subgraph-branches-design.md §2.6, §3.7 (C9).
finding-verifier
A graph agent that independently verifies code-review findings against the working tree. It exists because false positives kill hands-off trust faster than missed bugs do — and because an orchestrator verifying its own workers' findings inline can skip, fudge, or confirmation-bias the check. A graph can't: the structure IS the discipline.
How it works
parse (llm) ──▶ verify_each (map, max_concurrency 4) ──▶ done (end)
└─▶ verify_one (llm + fs_read/fs_cat/fs_grep), one branch PER finding
- parse — extracts every 🔴/🟡 finding from the spawn prompt into a structured list (id, severity verbatim, path, lines, self-contained claim). Extraction only — no judging.
- verify_each — a
mapnode fans out oneverify_onebranch per finding. Skipping a finding is structurally impossible; results collect in input order. - verify_one — reads the cited code (greps for moved code before concluding anything)
and answers ONE narrow question: does the cited code exist, and does it behave as the
claim says? Verdicts:
VERIFIED— with the decisive line(s) quoted verbatim (path:line).FALSE— the code doesn't exist anywhere or provably doesn't do what the claim says. Requires PROOF, not disagreement — doubt never lands here.UNVERIFIABLE— couldn't establish either way (runtime behavior, external systems). Kept, marked unverified.
- done — a deterministic
endnode emits the raw verdict list plus the caller contract (VERIFIED = keep + paste evidence; FALSE = drop + tally; UNVERIFIABLE = keep, marked). No final LLM step that could editorialize.
What it is NOT
- Not a second opinion. It never re-judges severity, style, or whether a finding "matters" — that authority stays with the reviewers and the orchestrator's rigor rules.
- Not a reviewer. It reads only what findings cite (plus greps to locate moved code).
Caller
Spawned by code-reviewer during its Finding Verifier
pass, ONCE per review, with the full 🔴/🟡 list and project_dir. If this agent isn't
installed, code-reviewer runs the same contract inline as a fallback.
Files
graph.yaml— the agent (no tools.sh; the graph grantsfs_read/fs_cat/fs_grepper node).