test: added additional test coverage to graph components

src/graph/llm.rs

@@ -468,6 +468,33 @@ mod tests {
         assert!(state.state().get(OUTPUT_KEY).is_none());
     }
 
+    #[test]
+    fn next_for_llm_node_success_routes_to_next() {
+        assert_eq!(
+            next_for_llm_node(Some("nx"), false, Some("fb")).unwrap(),
+            "nx"
+        );
+    }
+
+    #[test]
+    fn next_for_llm_node_failure_with_fallback_routes_to_fallback() {
+        assert_eq!(
+            next_for_llm_node(Some("nx"), true, Some("fb")).unwrap(),
+            "fb"
+        );
+    }
+
+    #[test]
+    fn next_for_llm_node_failure_without_fallback_routes_to_next() {
+        assert_eq!(next_for_llm_node(Some("nx"), true, None).unwrap(), "nx");
+    }
+
+    #[test]
+    fn next_for_llm_node_errors_without_next_or_fallback() {
+        assert!(next_for_llm_node(None, false, None).is_err());
+        assert!(next_for_llm_node(None, true, None).is_err());
+    }
+
     fn node_with_schema(updates: Option<HashMap<String, String>>, schema: Value) -> LlmNode {
         let mut n = node_with(updates);
         n.output_schema = Some(schema);

src/graph/types.rs

@@ -863,6 +863,27 @@ nodes:
         assert!(graph.conversation_starters.is_empty());
     }
 
+    #[test]
+    fn node_ids_lists_nodes_in_order() {
+        let yaml = r#"
+name: g
+start: first
+nodes:
+  first:
+    id: first
+    type: agent
+    agent: helper
+    prompt: hi
+    next: last
+  last:
+    id: last
+    type: end
+    output: done
+"#;
+        let graph: Graph = serde_yaml::from_str(yaml).unwrap();
+        assert_eq!(graph.node_ids(), vec!["first", "last"]);
+    }
+
     #[test]
     fn has_agent_node_detects_agent_nodes() {
         let with_agent = r#"

src/graph/validator.rs

@@ -464,6 +464,84 @@ mod tests {
         }
     }
 
+    fn input_node(id: &str, on_timeout: Option<&str>, next: Option<&str>) -> Node {
+        Node {
+            id: id.into(),
+            description: String::new(),
+            node_type: NodeType::Input(InputNode {
+                question: "?".into(),
+                default: None,
+                validation: None,
+                state_updates: None,
+                timeout: None,
+                on_timeout: on_timeout.map(String::from),
+            }),
+            next: next.map(String::from),
+        }
+    }
+
+    fn llm_node(id: &str, fallback: Option<&str>, next: Option<&str>) -> Node {
+        Node {
+            id: id.into(),
+            description: String::new(),
+            node_type: NodeType::Llm(LlmNode {
+                instructions: None,
+                prompt: "p".into(),
+                tools: None,
+                model: None,
+                temperature: None,
+                top_p: None,
+                fallback: fallback.map(String::from),
+                max_attempts: 1,
+                max_iterations: 10,
+                state_updates: None,
+                output_schema: None,
+                timeout: None,
+            }),
+            next: next.map(String::from),
+        }
+    }
+
+    #[test]
+    fn flags_missing_approval_on_timeout_target() {
+        let mut approval = approval_node("a", &["yes"], &[("yes", "end")], "end");
+        if let NodeType::Approval(ref mut n) = approval.node_type {
+            n.on_timeout = Some("ghost".into());
+        }
+        let graph = graph_with(vec![("a", approval), ("end", end_node("end"))], "a");
+        let result = validator().validate(&graph);
+        assert!(!result.is_valid());
+        assert!(result.errors.iter().any(|e| e.message.contains("ghost")));
+    }
+
+    #[test]
+    fn flags_missing_input_on_timeout_target() {
+        let graph = graph_with(
+            vec![
+                ("i", input_node("i", Some("ghost"), Some("end"))),
+                ("end", end_node("end")),
+            ],
+            "i",
+        );
+        let result = validator().validate(&graph);
+        assert!(!result.is_valid());
+        assert!(result.errors.iter().any(|e| e.message.contains("ghost")));
+    }
+
+    #[test]
+    fn flags_missing_llm_fallback_target() {
+        let graph = graph_with(
+            vec![
+                ("l", llm_node("l", Some("ghost"), Some("end"))),
+                ("end", end_node("end")),
+            ],
+            "l",
+        );
+        let result = validator().validate(&graph);
+        assert!(!result.is_valid());
+        assert!(result.errors.iter().any(|e| e.message.contains("ghost")));
+    }
+
     #[test]
     fn rag_node_without_documents_errors() {
         let graph = graph_with(