From 9b23247815ba5b2fffcf9b9a583423cfb56fe21d Mon Sep 17 00:00:00 2001 From: Alex Clarke Date: Mon, 24 Aug 2026 14:46:38 -0600 Subject: [PATCH] feat: flag duplicate helpers in code reviews with a repo-wide DRY check Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus --- assets/skills/code-review/SKILL.md | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/skills/code-review/SKILL.md b/assets/skills/code-review/SKILL.md index 9634685..002c7d3 100644 --- a/assets/skills/code-review/SKILL.md +++ b/assets/skills/code-review/SKILL.md @@ -97,6 +97,7 @@ A diff review is a review of THE CHANGE, not the whole file: - Does this change increase coupling between modules unnecessarily? - Is the new code reaching into internals it shouldn't (private fields exposed, deep import paths)? - Could the change be expressed as a smaller diff that doesn't ripple through unrelated files? +- New helper/utility/constant introduced? `fs_grep` for an existing equivalent in the repo before accepting it — duplicating an existing helper is a finding; cite the original's path so the author can reuse it. (The inverse is not a finding: do not demand a new abstraction to unify two mildly similar blocks.) ## 5. Footguns