fix(engine): carry full error chain in llm node fault text

A live code-reviewer run reported "LLM node failed: Failed to call
chat-completions api" with the root cause invisible, because the
state_updates fault text used `{e}` (top context only). Format with
`{e:#}` so fault scripts and warn! logs see the whole anyhow chain.
This commit is contained in:
Dark-Alex-17 committed 2026-09-14 10:50:34 -06:00
1 parent 5b4462135f
commit 7dac4620a8
1 file changed
+50 -5
+50 -5
View File
@@ -41,19 +41,19 @@ impl LlmNodeExecutor {
Some(schema) => match structured::extract(&raw, schema, parent_ctx).await { Some(schema) => match structured::extract(&raw, schema, parent_ctx).await {
Ok(value) => (value, None), Ok(value) => (value, None),
Err(e) => { Err(e) => {
warn!("llm node structured extraction failed: {e}"); warn!("llm node structured extraction failed: {e:#}");
( (
Value::String(format!("LLM node structured-extraction failed: {e}")), Value::String(format!("LLM node structured-extraction failed: {e:#}")),
Some(format!("structured-extraction failed: {e}")), Some(format!("structured-extraction failed: {e:#}")),
) )
} }
}, },
None => (Value::String(raw), None), None => (Value::String(raw), None),
}, },
Err(e) => { Err(e) => {
warn!("llm node failed: {e}"); warn!("llm node failed: {e:#}");
( (
Value::String(format!("LLM node failed: {e}")), Value::String(format!("LLM node failed: {e:#}")),
Some(format!("LLM call failed: {e:#}")), Some(format!("LLM call failed: {e:#}")),
) )
} }
@@ -773,4 +773,49 @@ mod tests {
"no output is recorded for an aborted node without state_updates" "no output is recorded for an aborted node without state_updates"
); );
} }
/// The fault text written through state_updates must carry the full
/// anyhow chain, not just the outermost context, so downstream fault
/// scripts can surface the root cause.
#[tokio::test]
async fn failure_text_in_state_updates_carries_full_error_chain() {
let mut u = HashMap::new();
u.insert("captured".into(), "{{output}}".into());
let mut node = node_with(Some(u));
node.prompt = "{{nope}}".into();
node.fallback = Some("fb".into());
let mut state = manager_with(&[]);
let mut ctx = RequestContext::new(Arc::new(AppState::test_default()), WorkingMode::Cmd);
ctx.agent = Some(Agent::test_new(AgentConfig::default()));
let abort = create_abort_signal();
let inner = state
.interpolate(&node.prompt)
.context("Failed to interpolate llm node prompt")
.expect_err("missing reference must fail interpolation");
assert_ne!(
format!("{inner:#}"),
format!("{inner}"),
"the chosen error must have more than one level of context"
);
let outcome = LlmNodeExecutor::execute("think", &node, &mut state, &mut ctx, &abort)
.await
.expect("a declared fallback turns the failure into a route");
assert_eq!(outcome, LlmExecutionOutcome::FellBack("fb".into()));
let captured = state
.state()
.get("captured")
.and_then(Value::as_str)
.expect("captured failure text is a string")
.to_string();
assert!(captured.starts_with("LLM node failed: "), "{captured}");
assert!(
captured.contains(
"Failed to interpolate llm node prompt: Template interpolation failed: 'nope' not found in state"
),
"{captured}"
);
}
} }