From 70b6d51b551c636a0d119226fef5c2dc7bae01a8 Mon Sep 17 00:00:00 2001
From: Alex Clarke <alex.j.tusa@gmail.com>
Date: Tue, 4 Aug 2026 13:12:37 -0600
Subject: [PATCH] test: Implemented unit tests to prevent regression on agent
 reasoning effort inheritance

---
 src/config/agent.rs           | 19 ++++++++++++++++++
 src/config/request_context.rs | 37 +++++++++++++++++++++++++++++++++++
 2 files changed, 56 insertions(+)

diff --git a/src/config/agent.rs b/src/config/agent.rs
index 41a50d6..d9d95ea 100644
--- a/src/config/agent.rs
+++ b/src/config/agent.rs
@@ -573,6 +573,25 @@ impl Agent {
             _ => bail!("No return value from '_instructions' function"),
         }
     }
+
+    #[cfg(test)]
+    pub fn test_new(config: AgentConfig) -> Self {
+        Self {
+            name: config.name.clone(),
+            config,
+            shared_variables: Default::default(),
+            session_variables: None,
+            shared_dynamic_instructions: None,
+            session_dynamic_instructions: None,
+            functions: Functions::default(),
+            rag: None,
+            graph_rags: Default::default(),
+            model: Model::default(),
+            vault: std::sync::Arc::new(Vault::default()),
+            is_graph: false,
+            enabled_tools: None,
+        }
+    }
 }
 
 impl RoleLike for Agent {
diff --git a/src/config/request_context.rs b/src/config/request_context.rs
index 7bb69d7..277641f 100644
--- a/src/config/request_context.rs
+++ b/src/config/request_context.rs
@@ -4139,6 +4139,7 @@ mod tests {
     use super::super::mcp_factory::McpFactory;
     use super::*;
     use crate::config::AppState;
+    use crate::config::agent::AgentConfig;
     use crate::function::{ToolCall, skill};
     use crate::mcp::{McpServer, McpServersConfig, McpTransportType};
     use crate::utils;
@@ -4322,6 +4323,42 @@ mod tests {
         assert_eq!(extracted.name(), "");
     }
 
+    #[test]
+    fn extract_role_agent_without_reasoning_effort_inherits_app_config() {
+        let mut ctx = create_test_ctx();
+        ctx.agent = Some(Agent::test_new(AgentConfig {
+            name: "test-agent".to_string(),
+            reasoning_effort: None,
+            ..AgentConfig::default()
+        }));
+        let app = AppConfig {
+            reasoning_effort: Some("max".to_string()),
+            ..AppConfig::default()
+        };
+
+        let extracted = ctx.extract_role(&app).unwrap();
+
+        assert_eq!(extracted.reasoning_effort(), Some("max".to_string()));
+    }
+
+    #[test]
+    fn extract_role_agent_with_explicit_reasoning_effort_takes_priority_over_app_config() {
+        let mut ctx = create_test_ctx();
+        ctx.agent = Some(Agent::test_new(AgentConfig {
+            name: "test-agent".to_string(),
+            reasoning_effort: Some("low".to_string()),
+            ..AgentConfig::default()
+        }));
+        let app = AppConfig {
+            reasoning_effort: Some("max".to_string()),
+            ..AppConfig::default()
+        };
+
+        let extracted = ctx.extract_role(&app).unwrap();
+
+        assert_eq!(extracted.reasoning_effort(), Some("low".to_string()));
+    }
+
     #[test]
     fn should_inject_skill_instructions_requires_function_calling() {
         let app = AppConfig {