From 5e2b9c98ad2d47d2665dc6af826597da265c0cc9 Mon Sep 17 00:00:00 2001
From: Alex Clarke <alex.j.tusa@gmail.com>
Date: Tue, 11 Aug 2026 13:55:59 -0600
Subject: [PATCH] fix(rag): stop the attach wizard from silently accepting an
 empty collection

`sample_point_id` returns `None` for a collection with no points, so the
UUID guard's `if let Some(..)` fell straight through and the wizard attached
happily. The result is a RAG that answers every query with zero hits and
never says why.

Sample once, then check for emptiness explicitly. This warns and asks rather
than hard-failing: an empty collection is not necessarily a mistake, since
another tool may be about to populate it, and none of the wizard's remaining
probes can distinguish that from a misconfiguration. The confirmation
defaults to "no" so it cannot be walked past by accident, and `attach`
already refuses to run non-interactively, so no unattended path reaches it.
---
 src/rag/mod.rs | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/src/rag/mod.rs b/src/rag/mod.rs
index daf4173..cbfd133 100644
--- a/src/rag/mod.rs
+++ b/src/rag/mod.rs
@@ -453,10 +453,32 @@ impl Rag {
 
         let collection = Select::new("Select collection:", collections).prompt()?;
 
+        let sample_id = QdrantProvider::sample_point_id(&host, &collection, api_key).await?;
+
+        // `None` means the scroll came back with no points at all: the collection
+        // is empty. Attaching is not necessarily wrong — another tool may be about
+        // to fill it — but accepting it silently yields a RAG that answers every
+        // query with nothing and never explains why, and none of the checks below
+        // can tell that apart from a misconfiguration. Ask, defaulting to no, so it
+        // cannot happen by accident. (`attach` already refuses to run
+        // non-interactively, so there is no unattended path through this prompt.)
+        if sample_id.is_none() {
+            println!(
+                "⚠️  Collection '{collection}' contains no points. Queries will return \
+                 nothing until something writes to it."
+            );
+            let attach_anyway = Confirm::new("Attach to this empty collection anyway?")
+                .with_default(false)
+                .prompt()?;
+            if !attach_anyway {
+                bail!("Collection '{collection}' is empty; nothing to attach to.");
+            }
+        }
+
         // Point IDs are read with `as_u64()`, which yields None for a JSON string.
         // A UUID-keyed collection would therefore return zero hits with no error,
         // so refuse it here instead of attaching something silently broken.
-        if let Some(raw_id) = QdrantProvider::sample_point_id(&host, &collection, api_key).await?
+        if let Some(raw_id) = &sample_id
             && raw_id.starts_with('"')
         {
             bail!(