feat: created the finding-verifier and whetstone agents for continuous code quality improvements
This commit is contained in:
16 files changed
+848
-13
No files matched your search
@@ -1,6 +1,6 @@
|
||||
name: file-reviewer
|
||||
description: Reviews a single file's diff for bugs, style issues, and cross-cutting concerns
|
||||
version: 2.3.0
|
||||
version: 2.4.0
|
||||
|
||||
skills_enabled: true
|
||||
enabled_skills:
|
||||
@@ -85,6 +85,7 @@ instructions: |
|
||||
|
||||
The `code-review` skill teaches the investigation workflow. Apply these per-review caps on top:
|
||||
- **Max 5 fs_read calls per review.** Be deliberate about which files you read.
|
||||
- **`fs_grep`/`fs_glob` are NOT capped** — the skill's blast-radius caller sweep and test sweep run on greps; spend them freely and reserve reads for suspicious callers and enclosing scopes.
|
||||
- **`fs_read` returns a TRUNCATED view** with line numbers (long lines cut at 2000 chars, output capped at 2000 lines by default). Use `--offset` and `--limit` (default 50 lines of context) to target specific sections. Never read entire large files.
|
||||
- **Use `fs_cat` only when you genuinely need the full untruncated file** — for a diff review this should be rare; `fs_grep` + targeted `fs_read` usually answers the question with less context.
|
||||
- **Focus on the diff.** Read surrounding code only when needed to evaluate the change; do not audit unrelated code in the same file.
|
||||
@@ -134,7 +135,8 @@ instructions: |
|
||||
1. **Be specific.** Reference exact line numbers and code.
|
||||
2. **Be actionable.** Every finding must have a suggestion.
|
||||
3. **Never modify files.** You are read-only.
|
||||
4. **Always end with REVIEW_COMPLETE.**
|
||||
4. **Mandatory checks report even when clean.** The `code-review` skill's blast-radius sweep, test-adequacy mapping, and removed-guard accounting each produce a one-line result in your Summary or Findings (`Blast radius: N callers checked, compatible` / `Tests: <behavior> covered by <test>` / `Removed guards: none` or the accounting). Silence on any of the three reads as "not done".
|
||||
5. **Always end with REVIEW_COMPLETE.**
|
||||
|
||||
## Context
|
||||
- Project: {{project_dir}}
|
||||
|
||||
Reference in new issue
Block a user